From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51498)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WKcoe-0002kK-94
	for qemu-devel@nongnu.org; Mon, 03 Mar 2014 19:02:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WKcoZ-0002ad-PA
	for qemu-devel@nongnu.org; Mon, 03 Mar 2014 19:02:36 -0500
Received: from mx1.redhat.com ([209.132.183.28]:21145)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1WKcoZ-0002aK-HG
	for qemu-devel@nongnu.org; Mon, 03 Mar 2014 19:02:31 -0500
Message-ID: <53151813.1070104@redhat.com>
Date: Mon, 03 Mar 2014 17:02:27 -0700
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1392978948-27416-1-git-send-email-cyliu@suse.com>
	<1392978948-27416-3-git-send-email-cyliu@suse.com>
In-Reply-To: <1392978948-27416-3-git-send-email-cyliu@suse.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="8x3oD4vfvO6mGSatoGMW31xAeKhlHaKWE"
Subject: Re: [Qemu-devel] [PATCH v21 02/25] qapi: output def_value_str when
 query command line options
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chunyan Liu <cyliu@suse.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Dong Xu Wang <wdongxu@linux.vnet.ibm.com>, stefanha@redhat.com

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--8x3oD4vfvO6mGSatoGMW31xAeKhlHaKWE
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 02/21/2014 03:35 AM, Chunyan Liu wrote:
> Change qapi interfaces to output the newly added def_value_str when que=
rying
> command line options.
>=20
> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
> Signed-off-by: Chunyan Liu <cyliu@suse.com>
> ---
>  qapi-schema.json   |    8 ++++++--
>  qmp-commands.hx    |    2 ++
>  util/qemu-config.c |    4 ++++
>  3 files changed, 12 insertions(+), 2 deletions(-)
>=20
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 473c096..83e5870 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -4010,12 +4010,16 @@
>  #
>  # @help: #optional human readable text string, not suitable for parsin=
g.
>  #
> -# Since 1.5
> +# @default: #optional string representation of the default used
> +#           if the option is omitted.
> +#
> +# Since 2.0

Not quite right.  This needs to be:

# @help: #optional human readable text string, not suitable for parsing.
#
# @default: #optional string representation of the default used
#           if the option is omitted (since 2.0).
#
# Since 1.5

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--8x3oD4vfvO6mGSatoGMW31xAeKhlHaKWE
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJTFRgUAAoJEKeha0olJ0NqJGsH/1LMGCUbl+SsWHNwXVCP8HOt
Fg7gtS1Iae4hrEBQnD2fz2JgzOHV6McqLdTH4XGsX7qL+tOdErN656cquIM9WGtD
ZY3hfBUt8qfEJ1KRECP96swUifcXqCSxqWGHRtCcllSMlu3x0+00+ImgibFFDrRE
oRgBItkRJryv9OlboLRoQS43pwNr5uVbmpjiz7NNyc/tNqBeCh2c0CyfJPrw2PpZ
nrUeo4TBIEBydb1KKD3tNmuAMcTNLbndoZyEm11lvLfKxKDg0uvJmMkAN0bhJz/S
d33OVrOYROdOtilWD8gLi5NVPiBfwSCHrTL3mT5Q4ncCxokT9tSpcZkMU73bxak=
=FKbZ
-----END PGP SIGNATURE-----

--8x3oD4vfvO6mGSatoGMW31xAeKhlHaKWE--