From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54022) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKma1-0007n8-4I for qemu-devel@nongnu.org; Tue, 04 Mar 2014 05:28:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WKmZv-0007cO-5a for qemu-devel@nongnu.org; Tue, 04 Mar 2014 05:28:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKmZu-0007cI-SQ for qemu-devel@nongnu.org; Tue, 04 Mar 2014 05:28:03 -0500 Message-ID: <5315AAAD.2070406@redhat.com> Date: Tue, 04 Mar 2014 11:27:57 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1393901250-3922-1-git-send-email-xbing6@gmail.com> <1393901250-3922-10-git-send-email-xbing6@gmail.com> In-Reply-To: <1393901250-3922-10-git-send-email-xbing6@gmail.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Discussion 09/10] exec: remove the unnecessary include of "exec-all.h" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Xuebing Wang , qemu-devel@nongnu.org Cc: afaerber@suse.de, stefanha@redhat.com Il 04/03/2014 03:47, Xuebing Wang ha scritto: > include/exec/exec-all.h should ONLY be included in target-xxx/* > - 'git grep -nw exec-all.h' confirms this Ok. Paolo > Signed-off-by: Xuebing Wang > --- > cputlb.c | 1 - > tcg/README | 2 +- > tci.c | 2 +- > 3 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/cputlb.c b/cputlb.c > index 724bdda..f1458a6 100644 > --- a/cputlb.c > +++ b/cputlb.c > @@ -23,7 +23,6 @@ > #include "cpu.h" /* target-xxx/cpu.h, required for CPUArchState etc */ > > #include "config.h" > -#include "exec/exec-all.h" > #include "exec/memory.h" > > #include "exec/cputlb.h" > diff --git a/tcg/README b/tcg/README > index f178212..0788bdc 100644 > --- a/tcg/README > +++ b/tcg/README > @@ -530,7 +530,7 @@ register. > inline TCG may still be faster for longer sequences. > > - The hard limit on the number of TCG instructions you can generate > - per guest instruction is set by MAX_OP_PER_INSTR in exec-all.h -- > + per guest instruction is set by MAX_OP_PER_INSTR in translate.h -- > you cannot exceed this without risking a buffer overrun. > > - Use the 'discard' instruction if you know that TCG won't be able to > diff --git a/tci.c b/tci.c > index 0202ed9..7b9d0af 100644 > --- a/tci.c > +++ b/tci.c > @@ -25,7 +25,7 @@ > #endif > > #include "qemu-common.h" > -#include "exec/exec-all.h" /* MAX_OPC_PARAM_IARGS */ > +#include "exec/translate.h" /* MAX_OPC_PARAM_IARGS */ > #include "tcg-op.h" > > /* Marker for missing code. */ >