From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 3/3] migration: add more traces
Date: Tue, 04 Mar 2014 13:26:07 +0100 [thread overview]
Message-ID: <5315C65F.6040103@redhat.com> (raw)
In-Reply-To: <1393906241-9296-4-git-send-email-aik@ozlabs.ru>
Il 04/03/2014 05:10, Alexey Kardashevskiy ha scritto:
> @@ -81,6 +81,7 @@ static void qemu_announce_self_iter(NICState *nic, void *opaque)
> uint8_t buf[60];
> int len;
>
> + trace_qemu_announce_self_iter();
Should include the nic or, even better, the six bytes of the MAC address.
Otherwise fine.
Paolo
next prev parent reply other threads:[~2014-03-04 12:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 4:10 [Qemu-devel] [PATCH v2 0/3] migration: add more traces Alexey Kardashevskiy
2014-03-04 4:10 ` [Qemu-devel] [PATCH v2 1/3] vl: add system_wakeup_request tracepoint Alexey Kardashevskiy
2014-03-04 4:10 ` [Qemu-devel] [PATCH v2 2/3] migration: extend section_start/end traces Alexey Kardashevskiy
2014-03-04 4:10 ` [Qemu-devel] [PATCH v2 3/3] migration: add more traces Alexey Kardashevskiy
2014-03-04 12:26 ` Paolo Bonzini [this message]
2014-03-04 15:14 ` [Qemu-devel] [PATCH v3] " Alexey Kardashevskiy
2014-03-06 20:04 ` Amit Shah
2014-03-10 17:17 ` Amit Shah
2014-03-10 22:35 ` Alexey Kardashevskiy
2014-03-10 22:42 ` Juan Quintela
2014-03-04 12:32 ` [Qemu-devel] [PATCH v2 0/3] " Paolo Bonzini
2014-03-05 9:10 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5315C65F.6040103@redhat.com \
--to=pbonzini@redhat.com \
--cc=aik@ozlabs.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).