From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45868)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WKoQM-0000mC-Ov
	for qemu-devel@nongnu.org; Tue, 04 Mar 2014 07:26:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WKoQF-0006Zp-Lz
	for qemu-devel@nongnu.org; Tue, 04 Mar 2014 07:26:18 -0500
Received: from mx1.redhat.com ([209.132.183.28]:63447)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WKoQF-0006Zb-Dl
	for qemu-devel@nongnu.org; Tue, 04 Mar 2014 07:26:11 -0500
Message-ID: <5315C65F.6040103@redhat.com>
Date: Tue, 04 Mar 2014 13:26:07 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1393906241-9296-1-git-send-email-aik@ozlabs.ru>
	<1393906241-9296-4-git-send-email-aik@ozlabs.ru>
In-Reply-To: <1393906241-9296-4-git-send-email-aik@ozlabs.ru>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 3/3] migration: add more traces
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org

Il 04/03/2014 05:10, Alexey Kardashevskiy ha scritto:
> @@ -81,6 +81,7 @@ static void qemu_announce_self_iter(NICState *nic, void *opaque)
>      uint8_t buf[60];
>      int len;
>
> +    trace_qemu_announce_self_iter();

Should include the nic or, even better, the six bytes of the MAC address.

Otherwise fine.

Paolo