From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46003)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xbing6@gmail.com>) id 1WKoQb-00010F-DA
	for qemu-devel@nongnu.org; Tue, 04 Mar 2014 07:26:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xbing6@gmail.com>) id 1WKoQP-0006bE-I0
	for qemu-devel@nongnu.org; Tue, 04 Mar 2014 07:26:33 -0500
Received: from mail-pd0-x231.google.com ([2607:f8b0:400e:c02::231]:41755)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xbing6@gmail.com>) id 1WKoQP-0006at-Ab
	for qemu-devel@nongnu.org; Tue, 04 Mar 2014 07:26:21 -0500
Received: by mail-pd0-f177.google.com with SMTP id g10so5048025pdj.22
	for <qemu-devel@nongnu.org>; Tue, 04 Mar 2014 04:26:20 -0800 (PST)
Message-ID: <5315C667.8050501@gmail.com>
Date: Tue, 04 Mar 2014 20:26:15 +0800
From: Xuebing wang <xbing6@gmail.com>
MIME-Version: 1.0
References: <1393901250-3922-1-git-send-email-xbing6@gmail.com>
	<1393901250-3922-3-git-send-email-xbing6@gmail.com>
	<5315A89F.40700@redhat.com>
In-Reply-To: <5315A89F.40700@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Discussion 02/10] NEED_CPU_H: remove '#include
 "cpu.h"' from include/qemu-common.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: afaerber@suse.de, stefanha@redhat.com


>>  #ifdef CONFIG_KVM
>>  #include <linux/kvm.h>
>>  #include <linux/kvm_para.h>
>> @@ -169,6 +178,7 @@ int kvm_init_vcpu(CPUState *cpu);
>>  int kvm_cpu_exec(CPUState *cpu);
>>
>>  #ifdef NEED_CPU_H
>> +#include "cpu.h" /* target-xxx/cpu.h, required for target_ulong */
>>
>>  void kvm_setup_guest_memory(void *start, size_t size);
>>  void kvm_flush_coalesced_mmio_buffer(void);
>
> Perhaps move debugging-related definitions to a new file 
> sysemu/kvm-debug.h and include it only from gdbstub.c, kvm-all.c, 
> kvm-stub.c, target-*/kvm.c.
>

Thanks for suggestion. This patch is strictly confined to "NEED_CPU_H" 
and making qemu build. :-)