From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51407)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xbing6@gmail.com>) id 1WKoeZ-0001Ig-B3
	for qemu-devel@nongnu.org; Tue, 04 Mar 2014 07:41:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xbing6@gmail.com>) id 1WKoeQ-00033S-Ua
	for qemu-devel@nongnu.org; Tue, 04 Mar 2014 07:40:59 -0500
Received: from mail-pb0-x229.google.com ([2607:f8b0:400e:c01::229]:60305)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xbing6@gmail.com>) id 1WKoeQ-00032x-M1
	for qemu-devel@nongnu.org; Tue, 04 Mar 2014 07:40:50 -0500
Received: by mail-pb0-f41.google.com with SMTP id jt11so5198067pbb.28
	for <qemu-devel@nongnu.org>; Tue, 04 Mar 2014 04:40:49 -0800 (PST)
Message-ID: <5315C9CB.9060509@gmail.com>
Date: Tue, 04 Mar 2014 20:40:43 +0800
From: Xuebing wang <xbing6@gmail.com>
MIME-Version: 1.0
References: <1393901250-3922-1-git-send-email-xbing6@gmail.com>
	<1393901250-3922-3-git-send-email-xbing6@gmail.com>
	<5315A89F.40700@redhat.com> <5315C269.4000602@gmail.com>
	<CAFEAcA_gw9x=ehsX486f5yHRQAS+Zxs1mzV5uYZGso_s5wZkLQ@mail.gmail.com>
In-Reply-To: <CAFEAcA_gw9x=ehsX486f5yHRQAS+Zxs1mzV5uYZGso_s5wZkLQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Discussion 02/10] NEED_CPU_H: remove '#include
 "cpu.h"' from include/qemu-common.h
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>

Hi Peter,

Thanks. You are correct, I don't know what I was thinking. :-)


On 03/04/2014 08:34 PM, Peter Maydell wrote:
> On 4 March 2014 12:09, Xuebing wang <xbing6@gmail.com> wrote:
>> target-*/gdbstub.c implementers only need to know gdbstub hooks (thus
>> gdbstub API), they don't care "cpu.h", although knowledge of "cpu.h" helps.
> The gdbstub.c code is just a tiny part of the target-* frontend; there
> is no way that anybody working on the gdbstub isn't going to know
> already about the cpu.h interfaces. In particular, the code in those
> files is generally implementing the gdbstub interfaces by looking
> at the internal details of the target CPU. The only reason they don't
> just include cpu.h is simply that at the moment qemu-common.h
> does it for them.
>
> thanks
> -- PMM
>

-- 
Thanks,
Xuebing Wang