From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56227)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WKost-0007u2-Iz
	for qemu-devel@nongnu.org; Tue, 04 Mar 2014 07:55:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WKoso-0000Qr-1E
	for qemu-devel@nongnu.org; Tue, 04 Mar 2014 07:55:47 -0500
Received: from mail-qa0-x232.google.com ([2607:f8b0:400d:c00::232]:48566)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WKosn-0000Qn-Tg
	for qemu-devel@nongnu.org; Tue, 04 Mar 2014 07:55:41 -0500
Received: by mail-qa0-f50.google.com with SMTP id o15so3330584qap.37
	for <qemu-devel@nongnu.org>; Tue, 04 Mar 2014 04:55:41 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5315CD49.8030500@redhat.com>
Date: Tue, 04 Mar 2014 13:55:37 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1393532883-12585-1-git-send-email-sw@weilnetz.de>
In-Reply-To: <1393532883-12585-1-git-send-email-sw@weilnetz.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Makefile: Add missing dependency for
 system emulation (fix build)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Cc: jcody@redhat.com, famz@redhat.com

Il 27/02/2014 21:28, Stefan Weil ha scritto:
> Comment from Makefile.objs:
>
> # block-obj-y is code used by both qemu system emulation and qemu-img
>
> The system emulation needs this dependency (which was missing in Makefile),
> otherwise builds without tools (or massive parallel builds) fail.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  Makefile |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index a28a3c8..a0dafbf 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -159,6 +159,7 @@ qemu-options.def: $(SRC_PATH)/qemu-options.hx
>  SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS))
>  SOFTMMU_SUBDIR_RULES=$(filter %-softmmu,$(SUBDIR_RULES))
>
> +$(SOFTMMU_SUBDIR_RULES): $(block-obj-y)
>  $(SOFTMMU_SUBDIR_RULES): config-all-devices.mak
>
>  subdir-%:
>

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>