From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKqki-0004Hw-Al for qemu-devel@nongnu.org; Tue, 04 Mar 2014 09:55:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WKqkZ-0006zW-Sr for qemu-devel@nongnu.org; Tue, 04 Mar 2014 09:55:28 -0500 Received: from mail-pb0-x235.google.com ([2607:f8b0:400e:c01::235]:32967) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKqkZ-0006zD-Ll for qemu-devel@nongnu.org; Tue, 04 Mar 2014 09:55:19 -0500 Received: by mail-pb0-f53.google.com with SMTP id rp16so5264824pbb.26 for ; Tue, 04 Mar 2014 06:55:18 -0800 (PST) Message-ID: <5315E94F.80006@gmail.com> Date: Tue, 04 Mar 2014 22:55:11 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1393499376-4374-1-git-send-email-wenchaoqemu@gmail.com> <878usqp13t.fsf@blackfin.pond.sub.org> <20140304083521.1e74a7ef@redhat.com> <8738iyhxxv.fsf@blackfin.pond.sub.org> In-Reply-To: <8738iyhxxv.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH V8 00/10] qapi script: support enum as discriminator and better enum name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: kwolf@redhat.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com, Luiz Capitulino ÓÚ 2014/3/4 21:53, Markus Armbruster дµÀ: > Luiz Capitulino writes: > >> On Tue, 04 Mar 2014 14:03:34 +0100 >> Markus Armbruster wrote: > [....] >>> Applies cleanly on Luiz's queue/qmp branch. >>> >>> I got a few questions on 04/10, but nothing major. Perhaps you'd like >>> to respin to address the nits picked by Eric and me. If not, we can ask >>> Luiz to clean up commit messages on commit as per Eric's review. >> Not sure if that's what you meant, but Wenchao could respin only 04/10. > Eric pointed out double S-o-B and a misspelling or two. > > [...] I will respin it tommorrow, thanks for your review.