From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKrhM-00021N-U1 for qemu-devel@nongnu.org; Tue, 04 Mar 2014 10:56:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WKrhG-00023P-CE for qemu-devel@nongnu.org; Tue, 04 Mar 2014 10:56:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:9818) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKrhG-00023I-2a for qemu-devel@nongnu.org; Tue, 04 Mar 2014 10:55:58 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s24FtubR010905 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 Mar 2014 10:55:57 -0500 Message-ID: <5315F78B.40100@redhat.com> Date: Tue, 04 Mar 2014 08:55:55 -0700 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="NFgMwbVSoF7bUR1CnfVtbM3xHo4wFuQaP" Subject: Re: [Qemu-devel] [PATCH] block: mirror - remove code cruft that has no function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --NFgMwbVSoF7bUR1CnfVtbM3xHo4wFuQaP Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/04/2014 08:35 AM, Jeff Cody wrote: > Originally, this built up the error message with the backing filename, > so that errp was set as follows: > error_set(errp, QERR_OPEN_FILE_FAILED, backing_filename); >=20 > However, we now propagate the local_error from the > bdrv_open_backing_file() call instead, making these 2 lines useless > code. >=20 > Signed-off-by: Jeff Cody > --- > block/mirror.c | 3 --- > 1 file changed, 3 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --NFgMwbVSoF7bUR1CnfVtbM3xHo4wFuQaP Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTFfeLAAoJEKeha0olJ0Nq8KsH/RDND7cYFzhuWHMZNRVx3XN9 9h6GfDZj6wU8seANFZQQVFZBAqFujD7RMyMf6ojNuTyTyT1hRP/nIK4F2OnPSVId iIzeInzXo+AJWep9xxjFkOUndEYa42ICtFaiqzGsDSeiefOsjv+vuuF/uNhuHtxa v3sMFIwIGMhCHmoMPFZWsXx9gNDwEuLPPjcasFawSyZ3LlIi304VkYQh1o0GvxHF 3sL/wjXaEfxtWUIWD7kZ8uIdkdBdc+yzk7KmiDD2urc5kr0xbiIi0rhOF8RpJ6cx z1I5qIXE+u9U47Z12HHQA/eGXE3FWfjiwJd97BRDv/01O480gt2AYZqt5LDGZAk= =RGvP -----END PGP SIGNATURE----- --NFgMwbVSoF7bUR1CnfVtbM3xHo4wFuQaP--