From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46675)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WKrpp-0006ih-61
	for Qemu-devel@nongnu.org; Tue, 04 Mar 2014 11:04:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WKrpk-0004hD-EZ
	for Qemu-devel@nongnu.org; Tue, 04 Mar 2014 11:04:49 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52779)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WKrpk-0004gv-7P
	for Qemu-devel@nongnu.org; Tue, 04 Mar 2014 11:04:44 -0500
Message-ID: <5315F992.1040504@redhat.com>
Date: Tue, 04 Mar 2014 17:04:34 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <5310489A.4060501@cisco.com> <53105EB0.3060702@redhat.com>
	<5315EEFE.6060605@cisco.com> <5315F40E.70102@redhat.com>
	<5315F813.5010904@cisco.com>
In-Reply-To: <5315F813.5010904@cisco.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Contribution - L2TPv3 transport
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Anton Ivanov (antivano)" <antivano@cisco.com>, Eric Blake <eblake@redhat.com>
Cc: "Qemu-devel@nongnu.org" <Qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>

Il 04/03/2014 16:58, Anton Ivanov (antivano) ha scritto:
> On 04/03/14 15:41, Eric Blake wrote:
>> On 03/04/2014 08:19 AM, Anton Ivanov (antivano) wrote:
>>> Attached is a revised version.
>> Better is to post a new top-level thread, with [PATCHv2] in the title.
>> Also, one of the v1 review comments was to break this into smaller
>> self-contained patches - that review request still applies.
>
> I will re-post in a minute.
>>
>> For more hints on patch submission, see:
>> http://wiki.qemu.org/Contribute/SubmitAPatch
>>
>>
> It is the smaller self-contained patch.
>
> It is only the L2TPv3 transport - that is what it takes to implement it.
> It is smaller in size than let's say tap or socket (half the size of tap).
>
> There is nothing else in it. It no longer touches any other common files
> either (besides adding its client init to net.c and clients.h).

I agree that there's not much to split here.

Paolo