From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60492) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKsiD-0007cM-WC for qemu-devel@nongnu.org; Tue, 04 Mar 2014 12:01:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WKsi9-0000S1-Pw for qemu-devel@nongnu.org; Tue, 04 Mar 2014 12:01:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKsi9-0000Ro-HL for qemu-devel@nongnu.org; Tue, 04 Mar 2014 12:00:57 -0500 Message-ID: <531606BD.8030501@redhat.com> Date: Tue, 04 Mar 2014 10:00:45 -0700 From: Eric Blake MIME-Version: 1.0 References: <1393941656-29068-1-git-send-email-pbonzini@redhat.com> <1393941656-29068-3-git-send-email-pbonzini@redhat.com> In-Reply-To: <1393941656-29068-3-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MXbHdP6IfWVdXmXFCfnAHoUhqWEGxBdjk" Subject: Re: [Qemu-devel] [PATCH 2.1 02/28] NUMA: check if the total numa memory size is equal to ram_size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: ehabkost@redhat.com, hutao@cn.fujitsu.com, mtosatti@redhat.com, imammedo@redhat.com, a.motakis@virtualopensystems.com, gaowanlong@cn.fujitsu.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --MXbHdP6IfWVdXmXFCfnAHoUhqWEGxBdjk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/04/2014 07:00 AM, Paolo Bonzini wrote: > From: Wanlong Gao >=20 > If the total number of the assigned numa nodes memory is not > equal to the assigned ram size, it will write the wrong data > to ACPI talb, then the guest will ignore the wrong ACPI table s/talb/table/ > and recognize all memory to one node. It's buggy, we should > check it to ensure that we write the right data to ACPI table. >=20 > Signed-off-by: Wanlong Gao > Reviewed-by: Eduardo Habkost > Signed-off-by: Paolo Bonzini > --- > numa.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > + if (numa_total !=3D ram_size) { > + fprintf(stderr, "qemu: numa nodes total memory size " > + "should equal to ram_size\n"); Is it worth also printing numa_total or ram_size values in this error message? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --MXbHdP6IfWVdXmXFCfnAHoUhqWEGxBdjk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTFga9AAoJEKeha0olJ0Nq/mEH/1lm7Tu3DzyADnK5LKfnguco lsOMhzX5CrDVHTT0iAayA5pyC/1D+2rLLco+yqLdJgcWiDS6yl52/TwbYPQvVH5K q0Avw6VJ4pc+FjHQ9Ogm/Japfq/ayrm/eQCLLxA3zY0q57dJiJ8QK8Z4NB8YU6sl EFn1LD6GZv1TWVxLwavwJuTOqX+CyHAIDdeNaFWaBZ20bSWbG2XncUq8DXPDGZEO F9LME12XbYpE8PuW73yIA95iKCudbaATNGrdZROqJLKTtnU59wvfKlA+DOwdob5D IzM7ZtLLiNH3yC/D6qJ+5HP7Jfh8RZwwdWywprOPFvXi9x8Q2juBI8KOUJ+KYnU= =3TL3 -----END PGP SIGNATURE----- --MXbHdP6IfWVdXmXFCfnAHoUhqWEGxBdjk--