From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36978)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WKt18-0004SZ-Ga
	for qemu-devel@nongnu.org; Tue, 04 Mar 2014 12:20:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WKt13-00078J-Rk
	for qemu-devel@nongnu.org; Tue, 04 Mar 2014 12:20:34 -0500
Received: from mx1.redhat.com ([209.132.183.28]:55453)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WKt13-000784-7C
	for qemu-devel@nongnu.org; Tue, 04 Mar 2014 12:20:29 -0500
Message-ID: <53160B3A.3000308@redhat.com>
Date: Tue, 04 Mar 2014 18:19:54 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1393941656-29068-1-git-send-email-pbonzini@redhat.com>
	<1393941656-29068-3-git-send-email-pbonzini@redhat.com>
	<531606BD.8030501@redhat.com>
In-Reply-To: <531606BD.8030501@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2.1 02/28] NUMA: check if the total numa
 memory size is equal to ram_size
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: ehabkost@redhat.com, hutao@cn.fujitsu.com, mtosatti@redhat.com, imammedo@redhat.com, a.motakis@virtualopensystems.com, gaowanlong@cn.fujitsu.com

Il 04/03/2014 18:00, Eric Blake ha scritto:
> On 03/04/2014 07:00 AM, Paolo Bonzini wrote:
>> From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>>
>> If the total number of the assigned numa nodes memory is not
>> equal to the assigned ram size, it will write the wrong data
>> to ACPI talb, then the guest will ignore the wrong ACPI table
>
> s/talb/table/
>
>> and recognize all memory to one node. It's buggy, we should
>> check it to ensure that we write the right data to ACPI table.
>>
>> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
>> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  numa.c | 11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>
>> +        if (numa_total != ram_size) {
>> +            fprintf(stderr, "qemu: numa nodes total memory size "
>> +                            "should equal to ram_size\n");
>
> Is it worth also printing numa_total or ram_size values in this error
> message?

Good idea.

Paolo