From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41668) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKtHW-0003Sb-CF for qemu-devel@nongnu.org; Tue, 04 Mar 2014 12:37:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WKtHR-0004nS-3q for qemu-devel@nongnu.org; Tue, 04 Mar 2014 12:37:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKtHQ-0004n6-RU for qemu-devel@nongnu.org; Tue, 04 Mar 2014 12:37:25 -0500 Message-ID: <53160F50.4040001@redhat.com> Date: Tue, 04 Mar 2014 10:37:20 -0700 From: Eric Blake MIME-Version: 1.0 References: <1393941656-29068-1-git-send-email-pbonzini@redhat.com> <1393941656-29068-29-git-send-email-pbonzini@redhat.com> In-Reply-To: <1393941656-29068-29-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oNOdbnW5bUJvV7QmOtNcVpqIEnS04MSnF" Subject: Re: [Qemu-devel] [PATCH 2.1 28/28] qmp: add query-memdev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: ehabkost@redhat.com, hutao@cn.fujitsu.com, mtosatti@redhat.com, imammedo@redhat.com, a.motakis@virtualopensystems.com, gaowanlong@cn.fujitsu.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oNOdbnW5bUJvV7QmOtNcVpqIEnS04MSnF Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/04/2014 07:00 AM, Paolo Bonzini wrote: > From: Hu Tao >=20 > Add qmp command query-memdev to query for information > of memory devices >=20 > Signed-off-by: Hu Tao > [Use QMP visitors instead of String visitors. - Paolo] > Signed-off-by: Paolo Bonzini > --- > numa.c | 64 ++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > qapi-schema.json | 31 +++++++++++++++++++++++++++ > qmp-commands.hx | 32 ++++++++++++++++++++++++++++ > 3 files changed, 127 insertions(+) >=20 > +++ b/qapi-schema.json > @@ -4576,3 +4576,34 @@ > ## > { 'enum': 'HostMemPolicy', > 'data': [ 'default', 'preferred', 'membind', 'interleave' ] } > + > +## > +# @Memdev: > +# > +# Information of memory device > +# > +# @size: memory device size > +# > +# @host-nodes: host nodes for its memory policy > +# > +# @policy: memory policy of memory device > +# > +# Since: 2.1 > +## > + > +{ 'type': 'Memdev', > + 'data': { > + 'size': 'size', > + 'host-nodes': ['uint16'], > + 'policy': 'str' }} Why is policy 'str', when you just defined 'HostMemPolicy' as an enum in the previous patch? Should this be using the enum? > +<- { "return": [ > + { > + "size": 536870912, > + "host-nodes": [0, 1], > + "policy": "bind" "bind" is not one of the values of HostMemPolicy - is that missing from patch 27/28? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --oNOdbnW5bUJvV7QmOtNcVpqIEnS04MSnF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTFg9QAAoJEKeha0olJ0NqbaoH/jbwBcOcmzpUS+/BJFlw5E49 mIPnndciqNslzemkdFrKJe0AJU071G/hB8u0bXVMF1eNzEUzolUZEvZFk1ZGUk9f sryavstAygRaHYn2Iowf8ydYwAMBR258TKnkZQ/Rgzvyx7nRMm8/GE4YFmS/eyG7 83C8peOfhgF12PgeAqHzBvCJaeBYhY0XDjN4oAroeK9DvzIPv7BJGJ48AmQal6bp 0J5UznJEi/NGeb99bYADGzAO1O9RpniE9ZGfk3diV85hxffBljFU2WPpem7W+lOs z50JvTYdt8dAjg6y15YLPCuhSv2H18GB2bxE0zw8tdm+H13F1i7taMwOaWYPj20= =fN0r -----END PGP SIGNATURE----- --oNOdbnW5bUJvV7QmOtNcVpqIEnS04MSnF--