From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45296) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKtWj-0002nd-S0 for qemu-devel@nongnu.org; Tue, 04 Mar 2014 12:53:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WKtWe-0001jS-Ts for qemu-devel@nongnu.org; Tue, 04 Mar 2014 12:53:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:62835) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKtWe-0001jO-L2 for qemu-devel@nongnu.org; Tue, 04 Mar 2014 12:53:08 -0500 Message-ID: <531612FB.40806@redhat.com> Date: Tue, 04 Mar 2014 10:52:59 -0700 From: Eric Blake MIME-Version: 1.0 References: <1393941656-29068-1-git-send-email-pbonzini@redhat.com> <1393941656-29068-16-git-send-email-pbonzini@redhat.com> In-Reply-To: <1393941656-29068-16-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gq1ScxNFHxoujr26mMSW33kReQWwXCRnx" Subject: Re: [Qemu-devel] [PATCH 2.1 15/28] numa: add -numa node, memdev= option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: ehabkost@redhat.com, hutao@cn.fujitsu.com, mtosatti@redhat.com, imammedo@redhat.com, a.motakis@virtualopensystems.com, gaowanlong@cn.fujitsu.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gq1ScxNFHxoujr26mMSW33kReQWwXCRnx Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/04/2014 07:00 AM, Paolo Bonzini wrote: > This option provides the infrastructure for binding guest NUMA nodes > to host NUMA nodes. For example: >=20 > -object memory-ram,size=3D1024M,policy=3Dmembind,host-nodes=3D0,id=3Dr= am-node0 \ > -numa node,nodeid=3D0,cpus=3D0,memdev=3Dram-node0 \ > -object memory-ram,size=3D1024M,policy=3Dinterleave,host-nodes=3D1-3,i= d=3Dram-node1 \ > -numa node,nodeid=3D1,cpus=3D1,memdev=3Dram-node1 >=20 > The option replaces "-numa node,mem=3D". >=20 > Signed-off-by: Paolo Bonzini > --- > +++ b/qapi-schema.json > @@ -4543,10 +4543,16 @@ > # @mem: #optional memory size of this node (equally divide total memor= y among > # nodes if omitted) > # > +# @memdev: #optional memory backend object. If specified for one node= , > +# it must be specified for all nodes. > +# > +# @mem: #optional memory size of this node; mutually exclusive with @m= emdev. No need to list @mem a second time, just add the mutual exclusion comment to the first listing. > =20 > DEF("numa", HAS_ARG, QEMU_OPTION_numa, > - "-numa node[,mem=3Dsize][,cpus=3Dcpu[-cpu]][,nodeid=3Dnode]\n", QE= MU_ARCH_ALL) > + "-numa node[,mem=3Dsize][,memdev=3Did][,cpus=3Dcpu[-cpu]][,nodeid=3D= node]\n", QEMU_ARCH_ALL) Since this is mutually exclusive, would it be better to split into two lines, as in: "-numa node[,mem=3Dsize][,cpus=3Dcpu[-cpu]][,nodeid=3Dnode]\n" "-numa node,memdev=3Did[,cpus=3Dcpu[-cpu]][,nodeid=3Dnode]\n" --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --gq1ScxNFHxoujr26mMSW33kReQWwXCRnx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTFhL7AAoJEKeha0olJ0NqL1QH/RR3zRVKTM38doOut1WQa5Fc sgxyM7qsxhwautVLhtUyZND0QrSVLq58LkGSga01tQb117Xw+anOABCC8zkbmEPM xOROCTdKUZSUVFhC9L0LmRTW3VNF1+W7nmR5nd7ZjPxXs0SUMSTU6Oeh1O32TEYH PSvEiqLlF86jYmE6pM5v1RrOevqbthZn0rYdRyf9EWQQBDfFQ93fqh4Qdjk/R2k/ cCPrW9JkS98kZfD6oqu6N/FqqbAf1USQPnA3E4t31NP51KyIPNH93H6yED4C0aS9 R3lAMT1r9tID4x+Dfl2/wG6e3CjbFbcV6w/+hbxnMEsqTrNSvWlFI2SvKm5hP0c= =2MgS -----END PGP SIGNATURE----- --gq1ScxNFHxoujr26mMSW33kReQWwXCRnx--