From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-devel <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH buildfix] block/gluster: Add missing argument to qemu_gluster_init() call
Date: Tue, 04 Mar 2014 21:18:09 +0100 [thread overview]
Message-ID: <53163501.3030601@suse.de> (raw)
In-Reply-To: <CAJSP0QV5s3qeiawRFm43f4Qc4su6Hjm-s7z9bkGfsze2bMPBWg@mail.gmail.com>
Am 04.03.2014 21:12, schrieb Stefan Hajnoczi:
> On Tue, Mar 4, 2014 at 9:00 PM, Andreas Färber <afaerber@suse.de> wrote:
>> Supply a required Error ** argument to qemu_gluster_init() in
>> qemu_gluster_reopen_prepare(), as done in qemu_gluster_open().
>>
>> Cc: Stefan Hajnoczi <stefanha@redhat.com>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
>> block/gluster.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Fixed my Gluster build environment, this shouldn't happen again in the future.
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Thanks, v2 sent with improved commit message.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-03-04 20:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 20:00 [Qemu-devel] [PATCH buildfix] block/gluster: Add missing argument to qemu_gluster_init() call Andreas Färber
2014-03-04 20:12 ` Stefan Hajnoczi
2014-03-04 20:18 ` Andreas Färber [this message]
2014-03-04 20:37 ` Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53163501.3030601@suse.de \
--to=afaerber@suse.de \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).