From: Eric Blake <eblake@redhat.com>
To: Amos Kong <akong@redhat.com>, qemu-devel@nongnu.org
Cc: libvir-list@redhat.com, pbonzini@redhat.com, armbru@redhat.com,
jyang@redhat.com, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 1/2] qmp: rename query_option_descs() to get_param_infolist()
Date: Tue, 04 Mar 2014 14:17:15 -0700 [thread overview]
Message-ID: <531642DB.60408@redhat.com> (raw)
In-Reply-To: <1393912317-26221-2-git-send-email-akong@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 646 bytes --]
On 03/03/2014 10:51 PM, Amos Kong wrote:
> Signed-off-by: Amos Kong <akong@redhat.com>
> ---
> util/qemu-config.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
No change from v2. To ease my review time, it is reasonable if you
amend the commit message to include my:
Reviewed-by: Eric Blake <eblake@redhat.com>
line, that way I know I don't have to focus heavily on a second review
of the same content. (http://wiki.qemu.org/Contribute/SubmitAPatch has
more hints about effective use of R-b tags)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-03-04 21:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 5:51 [Qemu-devel] [PATCH v3 0/2] fix query-command-line-options Amos Kong
2014-03-04 5:51 ` [Qemu-devel] [PATCH v3 1/2] qmp: rename query_option_descs() to get_param_infolist() Amos Kong
2014-03-04 21:17 ` Eric Blake [this message]
2014-03-04 5:51 ` [Qemu-devel] [PATCH v3 2/2] query-command-line-options: query all the options in qemu-options.hx Amos Kong
2014-03-04 22:03 ` Eric Blake
2014-03-05 6:40 ` Amos Kong
2014-03-05 15:58 ` Eric Blake
2014-03-05 18:50 ` [Qemu-devel] [libvirt] " Eric Blake
2014-03-06 2:32 ` Amos Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531642DB.60408@redhat.com \
--to=eblake@redhat.com \
--cc=akong@redhat.com \
--cc=armbru@redhat.com \
--cc=jyang@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=libvir-list@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).