From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKwiJ-0004FT-96 for qemu-devel@nongnu.org; Tue, 04 Mar 2014 16:17:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WKwiE-0000pO-Ri for qemu-devel@nongnu.org; Tue, 04 Mar 2014 16:17:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKwiE-0000pA-IK for qemu-devel@nongnu.org; Tue, 04 Mar 2014 16:17:18 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s24LHGcf009348 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 4 Mar 2014 16:17:17 -0500 Message-ID: <531642DB.60408@redhat.com> Date: Tue, 04 Mar 2014 14:17:15 -0700 From: Eric Blake MIME-Version: 1.0 References: <1393912317-26221-1-git-send-email-akong@redhat.com> <1393912317-26221-2-git-send-email-akong@redhat.com> In-Reply-To: <1393912317-26221-2-git-send-email-akong@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="J9a0PdVOHsLvVBsPbt6IDsAVirlhIh7Fj" Subject: Re: [Qemu-devel] [PATCH v3 1/2] qmp: rename query_option_descs() to get_param_infolist() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong , qemu-devel@nongnu.org Cc: libvir-list@redhat.com, pbonzini@redhat.com, armbru@redhat.com, jyang@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --J9a0PdVOHsLvVBsPbt6IDsAVirlhIh7Fj Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/03/2014 10:51 PM, Amos Kong wrote: > Signed-off-by: Amos Kong > --- > util/qemu-config.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) No change from v2. To ease my review time, it is reasonable if you amend the commit message to include my: Reviewed-by: Eric Blake line, that way I know I don't have to focus heavily on a second review of the same content. (http://wiki.qemu.org/Contribute/SubmitAPatch has more hints about effective use of R-b tags) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --J9a0PdVOHsLvVBsPbt6IDsAVirlhIh7Fj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTFkLbAAoJEKeha0olJ0NqkDgH/iAAcjXd+wPu86Mr3nXnjuey btJe1GRfNZPTyD01ZSAIxdusA214iPZlcYxnFLysq2vGlqphnG3S4zKzhjcUmsWA pqEvi0ACsx2e7qBJjlzBIUgMHlIlrPx8LmvpzYsMpz4UV+lExsRzIvt1Gvz7KmvU Q/KR1/80JIsFFiyKQZ455BfQHs7BQGk8u6tboLacUaInvAmAQKrde1OvxuxHdro9 jciyvd9WsVqrzL9Y0ezN+e8LUXvRoxkc30O9uQS70UMnvUs59oO6EGsBekwj1Wqu SkRlDDn7RNbrd8O8J/xHg+JolmAX6c+FqRuvph+0O93mLrfAl4SyKq2spZDtNs0= =DWxF -----END PGP SIGNATURE----- --J9a0PdVOHsLvVBsPbt6IDsAVirlhIh7Fj--