From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57129) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKxzd-0007On-V6 for qemu-devel@nongnu.org; Tue, 04 Mar 2014 17:39:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WKxzY-0004Rp-4j for qemu-devel@nongnu.org; Tue, 04 Mar 2014 17:39:21 -0500 Received: from cantor2.suse.de ([195.135.220.15]:40079 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WKxzX-0004Ri-V6 for qemu-devel@nongnu.org; Tue, 04 Mar 2014 17:39:16 -0500 Message-ID: <5316560E.5050801@suse.de> Date: Tue, 04 Mar 2014 23:39:10 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <530C5981.5010501@suse.de> In-Reply-To: <530C5981.5010501@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-next v1 0/6] SSI QOM cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , "qemu-devel@nongnu.org Developers" Cc: Peter Maydell Am 25.02.2014 09:51, schrieb Andreas F=E4rber: > Am 25.02.2014 09:46, schrieb Peter Crosthwaite: >> Ping! >=20 > Looked good, didn't get to applying them yet. I did wonder though a) wh= y > 1/6 is not renaming the parent field to verify and b) whether I can swa= p > d vs. dev naming in one hunk there while at it. a) i) SSISlave::dev was still in use one more time - fixed and renamed with ..._FROM_QDEV() macro drop. ii) SSIBus::qbus was still in use one more time - fixed and renamed in situ. b) Uniformly introduced DeviceState *dev for all affected initfns. Thanks, applied them to qom-next with the above changes: https://github.com/afaerber/qemu-cpu/commits/qom-next Regards, Andreas >>> Peter Crosthwaite (6): >>> ssi: Convert legacy casts from SSI_SLAVE->DEVICE >>> ssi: Remove legacy SSI_BUS->BUS cast >>> misc: max111x: Create abstract max111x class >>> misc: max111x: QOM casting sweep >>> ssi: Remove SSI_SLAVE_FROM_QDEV macro >>> block/m25p80: Remove FROM_SSI_SLAVE usages >>> >>> hw/arm/spitz.c | 9 +++++---- >>> hw/block/m25p80.c | 6 +++--- >>> hw/display/ads7846.c | 2 +- >>> hw/display/ssd0323.c | 4 ++-- >>> hw/misc/max111x.c | 46 +++++++++++++++++++++++++++++++++---------= ---- >>> hw/sd/ssi-sd.c | 2 +- >>> hw/ssi/ssi.c | 4 ++-- >>> include/hw/ssi.h | 1 - >>> 8 files changed, 47 insertions(+), 27 deletions(-) --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg