From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WL7Db-0005rM-OX for qemu-devel@nongnu.org; Wed, 05 Mar 2014 03:30:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WL7DU-00052I-EP for qemu-devel@nongnu.org; Wed, 05 Mar 2014 03:30:23 -0500 Received: from cantor2.suse.de ([195.135.220.15]:45579 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WL7DU-00051h-8F for qemu-devel@nongnu.org; Wed, 05 Mar 2014 03:30:16 -0500 Message-ID: <5316E094.2020508@suse.de> Date: Wed, 05 Mar 2014 09:30:12 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1393901749-5944-1-git-send-email-afaerber@suse.de> <531690FB.7060801@ozlabs.ru> In-Reply-To: <531690FB.7060801@ozlabs.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu 0/6] cpu: Unifying features parsing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org Cc: Igor Mammedov , Eduardo Habkost , Anthony Liguori , Peter Maydell Am 05.03.2014 03:50, schrieb Alexey Kardashevskiy: > On 03/04/2014 01:55 PM, Andreas F=C3=A4rber wrote: >> Hello, >> >> Prompted by Alexey's desire for tweakable PowerPCCPU properties but al= so by >> Peter's wish for ARMCPU properties, this series sets out to align cpu_= model >> parsing across targets. >> >> QemuOpts would've been nice to use, but on the one hand x86 and sparc = use >> QemuOpts-incompatible +foo and -foo syntax (which accumulate rather th= an apply >> immediately) and on the other linux-user and bsd-user don't use QemuOp= ts at all. >> >> The x86 implementation is closest to the proposed API, save for some l= aziness. >> SPARC is brought in line. And as fallback for the remaining targets a = new >> implementation, derived from x86 but supporting only key=3Dvalue forma= t, is added. >> >> To facilitate using this infrastructure, a generic CPU init function i= s created. >=20 >=20 > Besides the fact that this patchset does not support dynamic properties > (added by object_property_add(), and I used it in my initial patchset), Why would that be? I am using QOM object_property_parse() just like on x86 where we do have a mix of static and dynamic properties. Maybe you are using object_property_add() in the wrong place? It should be used in the instance_init function of the CPU - be it PowerPCCPU or a derived family/model - i.e. before cpu_ppc_init() returns. The same is necessary to support -global. > that works for SPAPR, just need to implement property statically (teste= d). Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg