From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51574)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WL86A-0006iM-OU
	for qemu-devel@nongnu.org; Wed, 05 Mar 2014 04:26:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WL85z-0001AM-CN
	for qemu-devel@nongnu.org; Wed, 05 Mar 2014 04:26:46 -0500
Received: from cantor2.suse.de ([195.135.220.15]:46638 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WL85z-0001AB-6T
	for qemu-devel@nongnu.org; Wed, 05 Mar 2014 04:26:35 -0500
Message-ID: <5316EDC9.2090609@suse.de>
Date: Wed, 05 Mar 2014 10:26:33 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1393969512-9468-1-git-send-email-stefanha@redhat.com>
	<1393969512-9468-2-git-send-email-stefanha@redhat.com>
In-Reply-To: <1393969512-9468-2-git-send-email-stefanha@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 1/4] qom: split object_property_set_link()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@amazon.com>, Paolo Bonzini <pbonzini@redhat.com>

Am 04.03.2014 22:45, schrieb Stefan Hajnoczi:
> The path resolution logic in object_property_set_link() should be a
> separate function.  This makes the code easier to read and maintain.
>=20
> More importantly, the error behavior of object_property_set_link() is
> dangerous.  It sets the link property object to NULL if an error occurs=
.
> A setter function should either succeed or fail, it shouldn't leave the
> value NULL on failure.
>=20
> This patch splits the code and fixes the error case so the old link
> property object is left in place on failure.
>=20
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

Since this code movement is a bit invasive due to the reindent (looks OK
though), can we do this in two steps please? First split, then fix?

Regards,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg