From: "Andreas Färber" <afaerber@suse.de>
To: Alex Williamson <alex.williamson@redhat.com>,
Kim Phillips <kim.phillips@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: peter.maydell@linaro.org, kim.phillips@freescale.com,
stuart.yoder@freescale.com, eric.auger@linaro.org,
qemu-devel@nongnu.org, agraf@suse.de,
a.motakis@virtualopensystems.com, kvmarm@lists.cs.columbia.edu,
christoffer.dall@linaro.org
Subject: Re: [Qemu-devel] [RFC 2/2] hw/misc/vfio: add vfio-platform support
Date: Wed, 05 Mar 2014 12:28:35 +0100 [thread overview]
Message-ID: <53170A63.40205@suse.de> (raw)
In-Reply-To: <1393982602.2895.166.camel@ul30vt.home>
Am 05.03.2014 02:23, schrieb Alex Williamson:
> On Tue, 2014-03-04 at 18:24 -0600, Kim Phillips wrote:
>> On Fri, 28 Feb 2014 11:03:18 -0700
>> Alex Williamson <alex.williamson@redhat.com> wrote:
>>
>>> This all looks reasonable, but I suspect it would be cleaner if
>>> vfio_find_get_group() was in a common file along with basic mmap and
>>> read/write access functions. Thanks,
>>
>> so rename existing hw/misc/vfio.c to its original name vfio-pci.c, and
>> load all common functions back into a vfio.c?
>
> I think hw/misc/vfio/{pci.c,common.c,platform.c,etc} Thanks,
What about hw/vfio/ then?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-03-05 11:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 2:37 [Qemu-devel] [RFC 0/2] platform device passthrough Kim Phillips
2014-02-26 2:37 ` [Qemu-devel] [RFC 1/2] hw/arm/virt: add a Calxeda XGMAC device Kim Phillips
2014-03-05 4:27 ` Eric Auger
2014-03-05 11:25 ` Andreas Färber
2014-03-06 2:27 ` Eric Auger
2014-02-26 2:37 ` [Qemu-devel] [RFC 2/2] hw/misc/vfio: add vfio-platform support Kim Phillips
2014-02-28 18:03 ` Alex Williamson
2014-03-05 0:24 ` Kim Phillips
2014-03-05 1:23 ` Alex Williamson
2014-03-05 11:28 ` Andreas Färber [this message]
2014-03-05 11:30 ` Paolo Bonzini
2014-03-05 7:56 ` Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53170A63.40205@suse.de \
--to=afaerber@suse.de \
--cc=a.motakis@virtualopensystems.com \
--cc=agraf@suse.de \
--cc=alex.williamson@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=eric.auger@linaro.org \
--cc=kim.phillips@freescale.com \
--cc=kim.phillips@linaro.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stuart.yoder@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).