From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47426)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WLA2k-0001Pl-14
	for qemu-devel@nongnu.org; Wed, 05 Mar 2014 06:31:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WLA2e-0003It-2J
	for qemu-devel@nongnu.org; Wed, 05 Mar 2014 06:31:21 -0500
Received: from mx1.redhat.com ([209.132.183.28]:44158)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WLA2d-0003Il-QQ
	for qemu-devel@nongnu.org; Wed, 05 Mar 2014 06:31:16 -0500
Message-ID: <53170AF3.3070604@redhat.com>
Date: Wed, 05 Mar 2014 12:30:59 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1393382272-29021-1-git-send-email-kim.phillips@linaro.org>	<1393382272-29021-3-git-send-email-kim.phillips@linaro.org>	<1393610598.26901.21.camel@ul30vt.home>	<20140304182418.7840d09f8254faaac0d36e65@linaro.org>
	<1393982602.2895.166.camel@ul30vt.home> <53170A63.40205@suse.de>
In-Reply-To: <53170A63.40205@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC 2/2] hw/misc/vfio: add vfio-platform support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, Alex Williamson <alex.williamson@redhat.com>, Kim Phillips <kim.phillips@linaro.org>
Cc: peter.maydell@linaro.org, kim.phillips@freescale.com, stuart.yoder@freescale.com, eric.auger@linaro.org, qemu-devel@nongnu.org, agraf@suse.de, a.motakis@virtualopensystems.com, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org

Il 05/03/2014 12:28, Andreas F=C3=A4rber ha scritto:
> Am 05.03.2014 02:23, schrieb Alex Williamson:
>> On Tue, 2014-03-04 at 18:24 -0600, Kim Phillips wrote:
>>> On Fri, 28 Feb 2014 11:03:18 -0700
>>> Alex Williamson <alex.williamson@redhat.com> wrote:
>>>
>>>> This all looks reasonable, but I suspect it would be cleaner if
>>>> vfio_find_get_group() was in a common file along with basic mmap and
>>>> read/write access functions.  Thanks,
>>>
>>> so rename existing hw/misc/vfio.c to its original name vfio-pci.c, an=
d
>>> load all common functions back into a vfio.c?
>>
>> I think hw/misc/vfio/{pci.c,common.c,platform.c,etc}  Thanks,
>
> What about hw/vfio/ then?

Agreed.

Paolo