qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: "Anton Ivanov (antivano)" <antivano@cisco.com>,
	"Qemu-devel@nongnu.org" <Qemu-devel@nongnu.org>
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] Contribution - L2TPv3 - resubmit
Date: Wed, 05 Mar 2014 12:45:30 +0100	[thread overview]
Message-ID: <53170E5A.10104@suse.de> (raw)
In-Reply-To: <53170860.2040100@cisco.com>

Hi,

Am 05.03.2014 12:20, schrieb Anton Ivanov (antivano):
> This is a functional driver which will interoperate versus most L2TPv3 
> implementations. It cannot be split into smaller patches - this is an 
> entire transport.
[snip]

Please see http://wiki.qemu.org/Contribute/SubmitAPatch - in particular
the patch should be sent as inline text rather than as attachment (so
that we can comment inline on it), also it is missing a Signed-off-by
(without it patches cannot get accepted) and the commit message should
be suitable for committing. Any other text can go into a cover letter
0/1 or below --- line. You also forgot to CC the net maintainer.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2014-03-05 11:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05 11:20 [Qemu-devel] Contribution - L2TPv3 - resubmit Anton Ivanov (antivano)
2014-03-05 11:45 ` Andreas Färber [this message]
2014-03-05 13:35   ` Stefan Hajnoczi
2014-03-05 14:10     ` Anton Ivanov (antivano)
2014-03-05 14:26       ` Stefan Hajnoczi
2014-03-05 17:00       ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53170E5A.10104@suse.de \
    --to=afaerber@suse.de \
    --cc=Qemu-devel@nongnu.org \
    --cc=antivano@cisco.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).