From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLAGZ-0000VD-MV for Qemu-devel@nongnu.org; Wed, 05 Mar 2014 06:45:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLAGT-00080s-LD for Qemu-devel@nongnu.org; Wed, 05 Mar 2014 06:45:39 -0500 Received: from cantor2.suse.de ([195.135.220.15]:48872 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLAGT-0007zF-1R for Qemu-devel@nongnu.org; Wed, 05 Mar 2014 06:45:33 -0500 Message-ID: <53170E5A.10104@suse.de> Date: Wed, 05 Mar 2014 12:45:30 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <53170860.2040100@cisco.com> In-Reply-To: <53170860.2040100@cisco.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] Contribution - L2TPv3 - resubmit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Anton Ivanov (antivano)" , "Qemu-devel@nongnu.org" Cc: Stefan Hajnoczi Hi, Am 05.03.2014 12:20, schrieb Anton Ivanov (antivano): > This is a functional driver which will interoperate versus most L2TPv3=20 > implementations. It cannot be split into smaller patches - this is an=20 > entire transport. [snip] Please see http://wiki.qemu.org/Contribute/SubmitAPatch - in particular the patch should be sent as inline text rather than as attachment (so that we can comment inline on it), also it is missing a Signed-off-by (without it patches cannot get accepted) and the commit message should be suitable for committing. Any other text can go into a cover letter 0/1 or below --- line. You also forgot to CC the net maintainer. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg