From: Eric Blake <eblake@redhat.com>
To: Bharata B Rao <bharata@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: aik@ozlabs.ru, stewart@linux.vnet.ibm.com, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH v2] ppc: Force CPU threads count to be a power of 2.
Date: Wed, 05 Mar 2014 06:59:29 -0700 [thread overview]
Message-ID: <53172DC1.9070505@redhat.com> (raw)
In-Reply-To: <1394008356-15320-1-git-send-email-bharata@linux.vnet.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 835 bytes --]
On 03/05/2014 01:32 AM, Bharata B Rao wrote:
> PowerPC kernel expects the number of SMT threads in a core to be a power
> of 2. Since QEMU doesn't enforce this, it leads to an early guest kernel
> crash if invalid threads count is specified.
>
> Prevent this crash and make it a graceful exit from QEMU itself by
> validating the user supplied threads count.
>
> Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
> ---
> Changes in v2: Use is_power_of_2() from QEMU itself instead of depending
> on libm.
> v1: https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg00660.html
> v0: https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg00355.html
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-03-05 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 8:32 [Qemu-devel] [PATCH v2] ppc: Force CPU threads count to be a power of 2 Bharata B Rao
2014-03-05 13:59 ` Eric Blake [this message]
2014-03-19 2:47 ` Bharata B Rao
2014-03-19 22:58 ` Andreas Färber
2014-03-05 22:51 ` Stewart Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53172DC1.9070505@redhat.com \
--to=eblake@redhat.com \
--cc=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=bharata@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stewart@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).