From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLCNF-0004Ph-N5 for qemu-devel@nongnu.org; Wed, 05 Mar 2014 09:00:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLCNA-0004Rm-0p for qemu-devel@nongnu.org; Wed, 05 Mar 2014 09:00:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36107) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLCN9-0004Q3-9q for qemu-devel@nongnu.org; Wed, 05 Mar 2014 09:00:35 -0500 Message-ID: <53172DC1.9070505@redhat.com> Date: Wed, 05 Mar 2014 06:59:29 -0700 From: Eric Blake MIME-Version: 1.0 References: <1394008356-15320-1-git-send-email-bharata@linux.vnet.ibm.com> In-Reply-To: <1394008356-15320-1-git-send-email-bharata@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CDIAO4RKqhoc8G7GC8QlWcOTOkinEOvwE" Subject: Re: [Qemu-devel] [PATCH v2] ppc: Force CPU threads count to be a power of 2. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao , qemu-devel@nongnu.org Cc: aik@ozlabs.ru, stewart@linux.vnet.ibm.com, agraf@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CDIAO4RKqhoc8G7GC8QlWcOTOkinEOvwE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/05/2014 01:32 AM, Bharata B Rao wrote: > PowerPC kernel expects the number of SMT threads in a core to be a powe= r > of 2. Since QEMU doesn't enforce this, it leads to an early guest kerne= l > crash if invalid threads count is specified. >=20 > Prevent this crash and make it a graceful exit from QEMU itself by > validating the user supplied threads count. >=20 > Signed-off-by: Bharata B Rao > --- > Changes in v2: Use is_power_of_2() from QEMU itself instead of dependin= g > on libm. > v1: https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg00660.html= > v0: https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg00355.html= Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CDIAO4RKqhoc8G7GC8QlWcOTOkinEOvwE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTFy3BAAoJEKeha0olJ0NqkAQH/3h0uzvEfsSf2JhRaEig2oZx Mlf06i1rNKITFWwQ3KGQsqM4WUA2PM6rHwLZPO4ONaQ9NO7iVickM2t8h9uS3NyX hF5zLHo1XjrNSCPzCw4R2Lok/1UW4DO8Mk/rPJCrvwLYu7QAarxsa8HitxB6NXfj DH+ko2LyIXLEtNAydNGTI6u5PD5ZANNIQoq88gZWPuMbvLUHpqR42YqsxWpdnzpa g6dcIZvmOpNXIHIkcNxwsvDjrpX0YuPtPO2rQkJefWKj0oazx2TxBLHWtr+l1snw WzPxcZZpHOlk5G1MfhaIWw9B5WX/KyBca/ITNvoZZpHs8UyWsRs3aIpqRGMnU5c= =h5HS -----END PGP SIGNATURE----- --CDIAO4RKqhoc8G7GC8QlWcOTOkinEOvwE--