From: "Anton Ivanov (antivano)" <antivano@cisco.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: "Andreas Färber" <afaerber@suse.de>,
"Qemu-devel@nongnu.org" <Qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] Contribution - L2TPv3 - resubmit
Date: Wed, 5 Mar 2014 14:10:11 +0000 [thread overview]
Message-ID: <53173041.5040702@cisco.com> (raw)
In-Reply-To: <20140305133500.GD20321@stefanha-thinkpad.muc.redhat.com>
ire transport.
>> [snip]
>>
>> Please see http://wiki.qemu.org/Contribute/SubmitAPatch - in particular
>> the patch should be sent as inline text rather than as attachment (so
>> that we can comment inline on it), also it is missing a Signed-off-by
>> (without it patches cannot get accepted) and the commit message should
>> be suitable for committing. Any other text can go into a cover letter
>> 0/1 or below --- line. You also forgot to CC the net maintainer.
> Besides the guidelines on the wiki a quick tip:
>
> Dry run git-send-email(1) by sending to your own email address first.
> Pick patch at random on the QEMU mailing list and compare whether the
> structure/style matches yours.
I tried :) It will not play nicely with a davmail + exchange combo (at
least in my config). Throws all kind of weird and wonderful errors. At
some point, I will look at it and fix it, but not today - it proved
easier to get it to work versus my personal email server.
I just finished re-subscribing from my own address, a patch resubmission
will follow shortly.
>
> Once you're ready, send to qemu-devel@nongnu.org and CC
> stefanha@redhat.com, afaerber@suse.de, eblake@redhat.com,
> pbonzini@redhat.com.
Thanks, will do shortly.
>
> If you get stuck, feel free to hop on #qemu on irc.oftc.net and we can
> chat about how to configure git-send-email(1).
I unstuck myself by choosing not to use corporate infra for the official
contribution sponsor which is not ideal. If I have the time I will look
through the use of the perl smtp module in git-send and fix it.
A.
next prev parent reply other threads:[~2014-03-05 14:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 11:20 [Qemu-devel] Contribution - L2TPv3 - resubmit Anton Ivanov (antivano)
2014-03-05 11:45 ` Andreas Färber
2014-03-05 13:35 ` Stefan Hajnoczi
2014-03-05 14:10 ` Anton Ivanov (antivano) [this message]
2014-03-05 14:26 ` Stefan Hajnoczi
2014-03-05 17:00 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53173041.5040702@cisco.com \
--to=antivano@cisco.com \
--cc=Qemu-devel@nongnu.org \
--cc=afaerber@suse.de \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).