From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52481) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLCWZ-0001Is-HU for Qemu-devel@nongnu.org; Wed, 05 Mar 2014 09:10:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLCWU-0007sO-JJ for Qemu-devel@nongnu.org; Wed, 05 Mar 2014 09:10:19 -0500 Received: from rcdn-iport-3.cisco.com ([173.37.86.74]:10012) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLCWU-0007sE-De for Qemu-devel@nongnu.org; Wed, 05 Mar 2014 09:10:14 -0500 From: "Anton Ivanov (antivano)" Date: Wed, 5 Mar 2014 14:10:11 +0000 Message-ID: <53173041.5040702@cisco.com> References: <53170860.2040100@cisco.com> <53170E5A.10104@suse.de> <20140305133500.GD20321@stefanha-thinkpad.muc.redhat.com> In-Reply-To: <20140305133500.GD20321@stefanha-thinkpad.muc.redhat.com> Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-ID: <5504E5911451154C9ED4483D8EF225AE@emea.cisco.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [Qemu-devel] Contribution - L2TPv3 - resubmit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: =?iso-8859-1?Q?Andreas_F=E4rber?= , "Qemu-devel@nongnu.org" ire transport. >> [snip] >> >> Please see http://wiki.qemu.org/Contribute/SubmitAPatch - in particular >> the patch should be sent as inline text rather than as attachment (so >> that we can comment inline on it), also it is missing a Signed-off-by >> (without it patches cannot get accepted) and the commit message should >> be suitable for committing. Any other text can go into a cover letter >> 0/1 or below --- line. You also forgot to CC the net maintainer. > Besides the guidelines on the wiki a quick tip: > > Dry run git-send-email(1) by sending to your own email address first. > Pick patch at random on the QEMU mailing list and compare whether the > structure/style matches yours. I tried :) It will not play nicely with a davmail + exchange combo (at=20 least in my config). Throws all kind of weird and wonderful errors. At=20 some point, I will look at it and fix it, but not today - it proved=20 easier to get it to work versus my personal email server. I just finished re-subscribing from my own address, a patch resubmission=20 will follow shortly. > > Once you're ready, send to qemu-devel@nongnu.org and CC > stefanha@redhat.com, afaerber@suse.de, eblake@redhat.com, > pbonzini@redhat.com. Thanks, will do shortly. > > If you get stuck, feel free to hop on #qemu on irc.oftc.net and we can > chat about how to configure git-send-email(1). I unstuck myself by choosing not to use corporate infra for the official=20 contribution sponsor which is not ideal. If I have the time I will look=20 through the use of the perl smtp module in git-send and fix it. A.=