From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLCZI-0002oo-BB for qemu-devel@nongnu.org; Wed, 05 Mar 2014 09:13:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLCZD-0000H4-BN for qemu-devel@nongnu.org; Wed, 05 Mar 2014 09:13:08 -0500 Message-ID: <531730D8.6010607@redhat.com> Date: Wed, 05 Mar 2014 15:12:40 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <49b80c368134449bb2b9093204aef6b6@BL2PR03MB210.namprd03.prod.outlook.com> <53170DFB.5050005@ozlabs.ru> <53172815.50806@redhat.com> <20140305134011.GH1993@redhat.com> In-Reply-To: <20140305134011.GH1993@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: "Hong-Hua.Yin@freescale.com" , Alexey Kardashevskiy , "qemu-devel@nongnu.org" , Li Zhang , "agraf@suse.de" , "qemu-ppc@nongnu.org" , "david@gibson.dropbear.id.au" Il 05/03/2014 14:40, Daniel P. Berrange ha scritto: > FWIW, I had requested this rename in the past but it was rejected :-( > > http://comments.gmane.org/gmane.comp.emulators.qemu/70783 I think we should revisit that. Path-based bus names are a good idea, but unfortunately it's not how things ended up working. We now have two namespaces: - one based on the device id + incremental number, where things created by the user can be addressed in a forwards-compatible way - another based on the bus type as soon as Alex/Markus's patch "qdev: Keep global allocation counter per bus", for things created by the board (and also by the user, but with no forwards guarantee of compatibility). So we could respin your patch, but with NULL bus name instead of "pci.0". Just a handful of machines are affected: alpha/typhoon.c: b = pci_register_bus(dev, "pci", mips/gt64xxx_pci.c: phb->bus = pci_register_bus(dev, "pci", pci-host/apb.c: phb->bus = pci_register_bus(DEVICE(phb), "pci", pci-host/bonito.c: phb->bus = pci_register_bus(DEVICE(dev), "pci", sh4/sh_pci.c: phb->bus = pci_register_bus(DEVICE(dev), "pci", pci-host/versatile.c: pci_bus_new_inplace(&s->pci_bus, sizeof(s->pci_bus), DEVICE(obj), "pci", plus pseries which has its own rules because it supports multiple PCI host bridges, but probably can also be changed from "pci" to NULL. Paolo