qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: "Hong-Hua.Yin@freescale.com" <Hong-Hua.Yin@freescale.com>,
	Alexey Kardashevskiy <aik@ozlabs.ru>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Li Zhang <zhlcindy@linux.vnet.ibm.com>,
	"agraf@suse.de" <agraf@suse.de>,
	"qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
	"david@gibson.dropbear.id.au" <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms
Date: Wed, 05 Mar 2014 15:33:39 +0100	[thread overview]
Message-ID: <531735C3.3010203@redhat.com> (raw)
In-Reply-To: <20140305142134.GI1993@redhat.com>

Il 05/03/2014 15:21, Daniel P. Berrange ha scritto:
>> alpha/typhoon.c:    b = pci_register_bus(dev, "pci",
>> mips/gt64xxx_pci.c:     phb->bus = pci_register_bus(dev, "pci",
>> pci-host/apb.c:    phb->bus = pci_register_bus(DEVICE(phb), "pci",
>> pci-host/bonito.c:    phb->bus = pci_register_bus(DEVICE(dev), "pci",
>> sh4/sh_pci.c:    phb->bus = pci_register_bus(DEVICE(dev), "pci",
>> pci-host/versatile.c:    pci_bus_new_inplace(&s->pci_bus, sizeof(s->pci_bus), DEVICE(obj), "pci",
>>
>> plus pseries which has its own rules because it supports multiple PCI
>> host bridges, but probably can also be changed from "pci" to NULL.
>
> I'm not sure I understand the effect of changing 'pci' to NULL in this
> code, from libvirt's POV. Would using NULL mean we can rely on using
> "pci.0" as the default PCI bus name or not ?

Yes.  But the next bus that the user creates (e.g. from a PCI bridge 
without an "id") would be "pci.1" instead of having a duplicate 
"pci.0").  Needs a bit more testing of course.

Paolo

  reply	other threads:[~2014-03-05 14:58 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-05 10:42 [Qemu-devel] QEMU: PCI bus name on PowerPC platforms Hong-Hua.Yin
2014-03-05 11:43 ` Alexey Kardashevskiy
2014-03-05 13:35   ` Paolo Bonzini
2014-03-05 13:40     ` Daniel P. Berrange
2014-03-05 14:12       ` Paolo Bonzini
2014-03-05 14:21         ` Daniel P. Berrange
2014-03-05 14:33           ` Paolo Bonzini [this message]
2014-03-05 14:40             ` Daniel P. Berrange
2014-04-10  9:24             ` Daniel P. Berrange
2014-04-11 11:40               ` Alexey Kardashevskiy
2014-04-11 12:27                 ` Eric Blake
2014-04-11 12:29                   ` Alexander Graf
2014-03-05 14:35           ` Andreas Färber
2014-03-05 14:38             ` Andreas Färber
2014-03-05 14:44               ` Paolo Bonzini
2014-03-05 15:15     ` Alexey Kardashevskiy
2014-03-06  2:25       ` Hong-Hua.Yin
2014-03-06  7:04       ` Hong-Hua.Yin
2014-03-06  7:07         ` Alexey Kardashevskiy
2014-03-06  7:21           ` Hong-Hua.Yin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=531735C3.3010203@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=Hong-Hua.Yin@freescale.com \
    --cc=agraf@suse.de \
    --cc=aik@ozlabs.ru \
    --cc=berrange@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=zhlcindy@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).