From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59274) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLCyK-0002Yr-9i for qemu-devel@nongnu.org; Wed, 05 Mar 2014 09:39:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLCyF-0001XA-0O for qemu-devel@nongnu.org; Wed, 05 Mar 2014 09:39:00 -0500 Message-ID: <531736FD.907@suse.de> Date: Wed, 05 Mar 2014 15:38:53 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <49b80c368134449bb2b9093204aef6b6@BL2PR03MB210.namprd03.prod.outlook.com> <53170DFB.5050005@ozlabs.ru> <53172815.50806@redhat.com> <20140305134011.GH1993@redhat.com> <531730D8.6010607@redhat.com> <20140305142134.GI1993@redhat.com> <53173616.7020207@suse.de> In-Reply-To: <53173616.7020207@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] QEMU: PCI bus name on PowerPC platforms List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , Paolo Bonzini Cc: "Hong-Hua.Yin@freescale.com" , Alexey Kardashevskiy , "qemu-devel@nongnu.org" , Li Zhang , "agraf@suse.de" , "qemu-ppc@nongnu.org" , "david@gibson.dropbear.id.au" Am 05.03.2014 15:35, schrieb Andreas F=C3=A4rber: > Am 05.03.2014 15:21, schrieb Daniel P. Berrange: >> On Wed, Mar 05, 2014 at 03:12:40PM +0100, Paolo Bonzini wrote: >>> Il 05/03/2014 14:40, Daniel P. Berrange ha scritto: >>>> FWIW, I had requested this rename in the past but it was rejected :-= ( >>>> >>>> http://comments.gmane.org/gmane.comp.emulators.qemu/70783 >>> >>> I think we should revisit that. >>> >>> Path-based bus names are a good idea, but unfortunately it's not how=20 >>> things ended up working. >>> >>> We now have two namespaces: >>> >>> - one based on the device id + incremental number, where things creat= ed >>> by the user can be addressed in a forwards-compatible way >>> >>> - another based on the bus type as soon as Alex/Markus's patch "qdev: >>> Keep global allocation counter per bus", for things created by the bo= ard >>> (and also by the user, but with no forwards guarantee of compatibilit= y). >>> >>> So we could respin your patch, but with NULL bus name instead of "pci= .0". >>> Just a handful of machines are affected: >>> >>> alpha/typhoon.c: b =3D pci_register_bus(dev, "pci", >>> mips/gt64xxx_pci.c: phb->bus =3D pci_register_bus(dev, "pci", >>> pci-host/apb.c: phb->bus =3D pci_register_bus(DEVICE(phb), "pci", >>> pci-host/bonito.c: phb->bus =3D pci_register_bus(DEVICE(dev), "pci= ", >>> sh4/sh_pci.c: phb->bus =3D pci_register_bus(DEVICE(dev), "pci", >>> pci-host/versatile.c: pci_bus_new_inplace(&s->pci_bus, sizeof(s->p= ci_bus), DEVICE(obj), "pci", >>> >>> plus pseries which has its own rules because it supports multiple PCI >>> host bridges, but probably can also be changed from "pci" to NULL. >> >> I'm not sure I understand the effect of changing 'pci' to NULL in this >> code, from libvirt's POV. Would using NULL mean we can rely on using >> "pci.0" as the default PCI bus name or not ? >=20 > I believe so, yes. See > https://github.com/afaerber/qemu-cpu/commit/ce1c9b4302a4458e73ae6a6a13f= 4e4ee121f79ea Err, on second thoughts that depends on the device not having an id=3D. I= f it does, then it's foo.0, not pci.0. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg