From: Richard Henderson <rth@twiddle.net>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-devel@nongnu.org,
Claudio Fontana <claudio.fontana@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 05/10] tcg-aarch64: Don't handle mov/movi intcg_out_opp
Date: Wed, 05 Mar 2014 06:47:48 -0800 [thread overview]
Message-ID: <53173914.8030400@twiddle.net> (raw)
In-Reply-To: <87bnxkdeuq.fsf@linaro.org>
On 03/05/2014 04:11 AM, Alex Bennée wrote:
>
> Richard Henderson <rth@twiddle.net> writes:
>
>> Signed-off-by: Richard Henderson <rth@twiddle.net>
>> ---
>> tcg/aarch64/tcg-target.c | 20 +++++++-------------
>> 1 file changed, 7 insertions(+), 13 deletions(-)
>>
> <snip>
>>
>> + case INDEX_op_mov_i64:
>> + case INDEX_op_mov_i32:
>> + case INDEX_op_movi_i64:
>> + case INDEX_op_movi_i32:
>> + /* Always implemented with tcg_out_mov/i, never with tcg_out_op. */
>> default:
>> - tcg_abort(); /* opcode not implemented */
>> + /* Opcode not implemented. */
>> + tcg_abort();
>> }
>> }
>
> Doesn't this fall through and abort for all mov ops? Have I missed
> somewhere else that ensures the ops don't come via tcg_out_op?
>
Yes, the switch statement in tcg_gen_code_common.
r~
next prev parent reply other threads:[~2014-03-05 14:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 17:04 [Qemu-devel] [PATCH 00/10] tcg/aarch64 cleanups Richard Henderson
2014-03-04 17:04 ` [Qemu-devel] [PATCH 01/10] tcg-aarch64: Enable builtin disassembler Richard Henderson
2014-03-05 12:03 ` Alex Bennée
2014-03-04 17:04 ` [Qemu-devel] [PATCH 02/10] tcg-aarch64: Remove redundant CPU_TLB_ENTRY_BITS check Richard Henderson
2014-03-05 12:03 ` [Qemu-devel] [PATCH 02/10] tcg-aarch64: Remove redundantCPU_TLB_ENTRY_BITS checkk Alex Bennée
2014-03-04 17:04 ` [Qemu-devel] [PATCH 03/10] tcg-aarch64: Change all ext variables to TCGType Richard Henderson
2014-03-04 17:04 ` [Qemu-devel] [PATCH 04/10] tcg-aarch64: Set ext based on TCG_OPF_64BIT Richard Henderson
2014-03-05 12:08 ` [Qemu-devel] [PATCH 04/10] tcg-aarch64: Set ext based onTCG_OPF_64BITT Alex Bennée
2014-03-05 17:17 ` [Qemu-devel] [PATCH 04/10] tcg-aarch64: Set ext basedonTCG_OPF_64BITTT Alex Bennée
2014-03-04 17:04 ` [Qemu-devel] [PATCH 05/10] tcg-aarch64: Don't handle mov/movi in tcg_out_op Richard Henderson
2014-03-05 12:11 ` [Qemu-devel] [PATCH 05/10] tcg-aarch64: Don't handle mov/movi intcg_out_opp Alex Bennée
2014-03-05 14:47 ` Richard Henderson [this message]
2014-03-04 17:04 ` [Qemu-devel] [PATCH 06/10] tcg-aarch64: Hoist common argument loads in tcg_out_op Richard Henderson
2014-03-05 12:14 ` [Qemu-devel] [PATCH 06/10] tcg-aarch64: Hoist common argument loadsin tcg_out_opp Alex Bennée
2014-03-05 14:53 ` Richard Henderson
2014-03-04 17:04 ` [Qemu-devel] [PATCH 07/10] tcg-aarch64: Remove the shift_imm parameter from tcg_out_cmp Richard Henderson
2014-03-05 12:15 ` [Qemu-devel] [PATCH 07/10] tcg-aarch64: Remove the shift_immparameter from tcg_out_cmpp Alex Bennée
2014-03-04 17:04 ` [Qemu-devel] [PATCH 08/10] tcg-aarch64: Use intptr_t apropriately Richard Henderson
2014-03-04 17:04 ` [Qemu-devel] [PATCH 09/10] tcg-aarch64: Simplify tcg_out_ldst_9 encoding Richard Henderson
2014-03-04 17:04 ` [Qemu-devel] [PATCH 10/10] tcg-aarch64: Remove nop from qemu_st slow path Richard Henderson
2014-03-06 10:06 ` [Qemu-devel] [PATCH 00/10] tcg/aarch64 cleanups Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53173914.8030400@twiddle.net \
--to=rth@twiddle.net \
--cc=alex.bennee@linaro.org \
--cc=claudio.fontana@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).