From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33232)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WLD72-0004Q3-Eu
	for qemu-devel@nongnu.org; Wed, 05 Mar 2014 09:48:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WLD6v-0004gs-UG
	for qemu-devel@nongnu.org; Wed, 05 Mar 2014 09:48:00 -0500
Received: from mail-qg0-x231.google.com ([2607:f8b0:400d:c04::231]:41656)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WLD6v-0004go-PQ
	for qemu-devel@nongnu.org; Wed, 05 Mar 2014 09:47:53 -0500
Received: by mail-qg0-f49.google.com with SMTP id z60so3156078qgd.8
	for <qemu-devel@nongnu.org>; Wed, 05 Mar 2014 06:47:53 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <53173914.8030400@twiddle.net>
Date: Wed, 05 Mar 2014 06:47:48 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1393952650-16802-1-git-send-email-rth@twiddle.net>
	<1393952650-16802-6-git-send-email-rth@twiddle.net>
	<87bnxkdeuq.fsf@linaro.org>
In-Reply-To: <87bnxkdeuq.fsf@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 05/10] tcg-aarch64: Don't handle mov/movi
 intcg_out_opp
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, Claudio Fontana <claudio.fontana@gmail.com>

On 03/05/2014 04:11 AM, Alex Bennée wrote:
> 
> Richard Henderson <rth@twiddle.net> writes:
> 
>> Signed-off-by: Richard Henderson <rth@twiddle.net>
>> ---
>>  tcg/aarch64/tcg-target.c | 20 +++++++-------------
>>  1 file changed, 7 insertions(+), 13 deletions(-)
>>
> <snip>
>>  
>> +    case INDEX_op_mov_i64:
>> +    case INDEX_op_mov_i32:
>> +    case INDEX_op_movi_i64:
>> +    case INDEX_op_movi_i32:
>> +        /* Always implemented with tcg_out_mov/i, never with tcg_out_op.  */
>>      default:
>> -        tcg_abort(); /* opcode not implemented */
>> +        /* Opcode not implemented.  */
>> +        tcg_abort();
>>      }
>>  }
> 
> Doesn't this fall through and abort for all mov ops? Have I missed
> somewhere else that ensures the ops don't come via tcg_out_op?
> 
Yes, the switch statement in tcg_gen_code_common.


r~