From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33892) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLF3l-0008Az-MJ for qemu-devel@nongnu.org; Wed, 05 Mar 2014 11:52:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLF3g-00031B-0E for qemu-devel@nongnu.org; Wed, 05 Mar 2014 11:52:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLF3f-000315-MF for qemu-devel@nongnu.org; Wed, 05 Mar 2014 11:52:39 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s25GqcRm028812 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 5 Mar 2014 11:52:38 -0500 Message-ID: <53175655.6040203@redhat.com> Date: Wed, 05 Mar 2014 09:52:37 -0700 From: Eric Blake MIME-Version: 1.0 References: <1393860533-2063-1-git-send-email-mreitz@redhat.com> <1393860533-2063-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1393860533-2063-2-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="n75imf4GDWVXALxU1Skf91PWn04Xhf2Bw" Subject: Re: [Qemu-devel] [PATCH 01/10] qdict: Add qdict_join() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --n75imf4GDWVXALxU1Skf91PWn04Xhf2Bw Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/03/2014 08:28 AM, Max Reitz wrote: > This function joins two QDicts by absorbing one into the other. >=20 > Signed-off-by: Max Reitz > --- > include/qapi/qmp/qdict.h | 3 +++ > qobject/qdict.c | 32 ++++++++++++++++++++++++++++++++ > 2 files changed, 35 insertions(+) >=20 Reviewed-by: Eric Blake However, I think you should expand the testsuite to cover this addition (can be a followup) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --n75imf4GDWVXALxU1Skf91PWn04Xhf2Bw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTF1ZVAAoJEKeha0olJ0NqN/sH/2ycVM7UIeDF+paoCQDTTDr+ 9HM8w9pbMwmiRIwCFo/x4n6Pj1SU92iQlZSxWTR5N2au/U0NUXsFO/axV/K1JpwG qec4YaSmlOCGpd6XOw9JBXdfLmI9Tk031csg9VCJ3Ic22NolbL7MSmhiCxA72kOd NiXb2ahGl8jseDaiQ8ssuTBLyiYuDGCei+Sc3C1g+HA2osOZAhtwkKYOTzTEQdLK HQiJEG3o7a+7d3r4N8G8PHvVNHr5dUHY7kZ2SI7UPt5adCx6bASJ3khXfo/65yYU 7OZln5Gf5/Rdez3+hLrCjohwsRtgI1ywwFTnryX+R+JomrPifND8konnpuc17hE= =iw2w -----END PGP SIGNATURE----- --n75imf4GDWVXALxU1Skf91PWn04Xhf2Bw--