From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLFbj-00051Q-NG for qemu-devel@nongnu.org; Wed, 05 Mar 2014 12:27:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLFbe-0007n5-AM for qemu-devel@nongnu.org; Wed, 05 Mar 2014 12:27:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39193) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLFbe-0007mt-09 for qemu-devel@nongnu.org; Wed, 05 Mar 2014 12:27:46 -0500 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s25HRi8D002481 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 5 Mar 2014 12:27:45 -0500 Message-ID: <53175E8F.1010904@redhat.com> Date: Wed, 05 Mar 2014 10:27:43 -0700 From: Eric Blake MIME-Version: 1.0 References: <1393860533-2063-1-git-send-email-mreitz@redhat.com> <1393860533-2063-11-git-send-email-mreitz@redhat.com> In-Reply-To: <1393860533-2063-11-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2rLUKlgnq8ibmJFOuuDd4NsKBxkLBTO7h" Subject: Re: [Qemu-devel] [PATCH 10/10] iotests: Add test for the JSON protocol List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2rLUKlgnq8ibmJFOuuDd4NsKBxkLBTO7h Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/03/2014 08:28 AM, Max Reitz wrote: > Add a test for the JSON protocol driver. >=20 > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/084 | 114 +++++++++++++++++++++++++++++++++++++= ++++++++ > + > +# Taken from test 072 The comment is okay, but... > +echo > +echo "=3D=3D=3D Testing nested image formats (072) =3D=3D=3D" =2E..maybe this echo should be updated to mention test 084. > +$QEMU_IO -c 'read -P 42 0 512' -c 'read -P 23 512 512' \ > + -c 'read -P 66 1024 512' "json:{ > + \"driver\": \"$IMGFMT\", > + \"file\": { > + \"driver\": \"$IMGFMT\", > + \"file\": { > + \"filename\": \"$TEST_IMG\" Are we guaranteed that $TEST_IMG will not contain any " which would render this invalid JSON? > + > +# Taken from test 071 > +echo > +echo "=3D=3D=3D Testing blkdebug (071) =3D=3D=3D" Hmm - now you're mentioning yet another test id different than 084. So I guess this was just a hint that you are reproducing earlier tests but now with the context of a json: protocol. Still, doesn't "Testing blkdebug" convey sufficient information, without also needing "(071)" for confusion? At any rate, I don't think this affects the coverage of the test. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --2rLUKlgnq8ibmJFOuuDd4NsKBxkLBTO7h Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTF16PAAoJEKeha0olJ0Nq1tAIAI8krvz8ae8FcAkHI9ez3CLS OHar1uE5Mc7vDyO6CMD/13HN4R+Wd+bPBg/NOGwytjBB0+jJz9YTSPxvYJuFX2Vf 8RRSxA6N89WVfY6tHDJninDTCaS9PhdqIfFnpSLEEHtbAVId7yKjW3f6kS6V5aov GHAqTPzzt8DLws0YSTB8Bcnhp3kj9K1/A13Q7L/imFDeP5dFMEX51Kx84HnxysNQ 0QjF2kn+YSSxWqjikq4wxa2aYpxhKbLeal29wprnLZXM9Bb4LYHHyKHiaR+ljkgA /LZBa7jfcHc/+vc+LsDSlgWqDrS2AekoZMjJoOWeH1ZtxJ5j1LpxtpBQ+DzxA+I= =Wjxw -----END PGP SIGNATURE----- --2rLUKlgnq8ibmJFOuuDd4NsKBxkLBTO7h--