From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLICE-0004SQ-An for qemu-devel@nongnu.org; Wed, 05 Mar 2014 15:13:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLIC8-0007PA-Ba for qemu-devel@nongnu.org; Wed, 05 Mar 2014 15:13:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:23268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLIC8-0007P5-2m for qemu-devel@nongnu.org; Wed, 05 Mar 2014 15:13:36 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s25KDZGg029344 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 5 Mar 2014 15:13:35 -0500 Message-ID: <5317856C.40105@redhat.com> Date: Wed, 05 Mar 2014 21:13:32 +0100 From: Max Reitz MIME-Version: 1.0 References: <1393860533-2063-1-git-send-email-mreitz@redhat.com> <1393860533-2063-2-git-send-email-mreitz@redhat.com> <53175655.6040203@redhat.com> In-Reply-To: <53175655.6040203@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/10] qdict: Add qdict_join() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: Kevin Wolf , Stefan Hajnoczi On 05.03.2014 17:52, Eric Blake wrote: > On 03/03/2014 08:28 AM, Max Reitz wrote: >> This function joins two QDicts by absorbing one into the other. >> >> Signed-off-by: Max Reitz >> --- >> include/qapi/qmp/qdict.h | 3 +++ >> qobject/qdict.c | 32 ++++++++++++++++++++++++++++++++ >> 2 files changed, 35 insertions(+) >> > Reviewed-by: Eric Blake > > However, I think you should expand the testsuite to cover this addition > (can be a followup) I keep forgetting the tests for QDict... Yes, I'll include it in v2. Thanks, Max