From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52088)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WLIE0-0006kZ-9U
	for qemu-devel@nongnu.org; Wed, 05 Mar 2014 15:15:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WLIDq-0008Q7-Ko
	for qemu-devel@nongnu.org; Wed, 05 Mar 2014 15:15:31 -0500
Received: from mx1.redhat.com ([209.132.183.28]:50636)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1WLIDq-0008O5-A3
	for qemu-devel@nongnu.org; Wed, 05 Mar 2014 15:15:22 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s25KFKQm012308
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 5 Mar 2014 15:15:20 -0500
Message-ID: <531785D4.8080506@redhat.com>
Date: Wed, 05 Mar 2014 21:15:16 +0100
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1393860533-2063-1-git-send-email-mreitz@redhat.com>
	<1393860533-2063-11-git-send-email-mreitz@redhat.com>
	<53175E8F.1010904@redhat.com>
In-Reply-To: <53175E8F.1010904@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 10/10] iotests: Add test for the JSON
	protocol
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

On 05.03.2014 18:27, Eric Blake wrote:
> On 03/03/2014 08:28 AM, Max Reitz wrote:
>> Add a test for the JSON protocol driver.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> ---
>>   tests/qemu-iotests/084     | 114 +++++++++++++++++++++++++++++++++++++++++++++
>> +
>> +# Taken from test 072
> The comment is okay, but...
>
>> +echo
>> +echo "=== Testing nested image formats (072) ==="
> ...maybe this echo should be updated to mention test 084.
>
>> +$QEMU_IO -c 'read -P 42 0 512' -c 'read -P 23 512 512' \
>> +         -c 'read -P 66 1024 512' "json:{
>> +    \"driver\": \"$IMGFMT\",
>> +    \"file\": {
>> +        \"driver\": \"$IMGFMT\",
>> +        \"file\": {
>> +            \"filename\": \"$TEST_IMG\"
> Are we guaranteed that $TEST_IMG will not contain any " which would
> render this invalid JSON?

Probably not, but do you have an idea to circumvent this?

>> +
>> +# Taken from test 071
>> +echo
>> +echo "=== Testing blkdebug (071) ==="
> Hmm - now you're mentioning yet another test id different than 084.  So
> I guess this was just a hint that you are reproducing earlier tests but
> now with the context of a json: protocol.  Still, doesn't "Testing
> blkdebug" convey sufficient information, without also needing "(071)"
> for confusion?

Probably, yes. I think I'll leave it in the comments for reference and 
remove it from the echoes.


Max

> At any rate, I don't think this affects the coverage of
> the test.
>
> Reviewed-by: Eric Blake <eblake@redhat.com>