From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLIVn-0007uj-0q for qemu-devel@nongnu.org; Wed, 05 Mar 2014 15:33:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLIVi-0006HJ-Lo for qemu-devel@nongnu.org; Wed, 05 Mar 2014 15:33:54 -0500 Message-ID: <53178A27.1050103@redhat.com> Date: Wed, 05 Mar 2014 13:33:43 -0700 From: Eric Blake MIME-Version: 1.0 References: <1394035840-1584-1-git-send-email-imammedo@redhat.com> <1394035840-1584-3-git-send-email-imammedo@redhat.com> In-Reply-To: <1394035840-1584-3-git-send-email-imammedo@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BCGnoucBdqqh6Wvp7PAFuJtx2fglo4g9o" Subject: Re: [Qemu-devel] [PATCH v3 2/2] vl: convert -m to QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: kwolf@redhat.com, aliguori@amazon.com, qemu-trivial@nongnu.org, coreyb@linux.vnet.ibm.com, mjt@tls.msk.ru, mreitz@redhat.com, stefanha@redhat.com, lcapitulino@redhat.com, pbonzini@redhat.com, akong@redhat.com, lersek@redhat.com, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BCGnoucBdqqh6Wvp7PAFuJtx2fglo4g9o Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/05/2014 09:10 AM, Igor Mammedov wrote: > Adds option to -m > "size" - startup memory amount >=20 > For compatibility with legacy CLI if suffix-less number is passed, > it assumes amount in Mb. >=20 > Otherwise user is free to use suffixed number using suffixes b,k/K,M,G >=20 > Signed-off-by: Igor Mammedov > Reviewed-by: Eric Blake > Signed-off-by: Paolo Bonzini > --- > v2: > - suggested by Andreas F=C3=A4rber > * s/fprintf/error_report/ > * rename 'mem' option to 'size' > - fix conflict with missing numa QemuOpts Given the amount of rework in v2, it may have been smarter to drop my R-b tag. But beyond Andreas' findings of missing s/mem/size/ instances, I'm not spotting any problems, so if that's the only fix you make for v4, you can keep my R-b. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --BCGnoucBdqqh6Wvp7PAFuJtx2fglo4g9o Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTF4onAAoJEKeha0olJ0Nqbk0H+QF4Zk3pGNmb6ikRpKgr/Xwk EiYdTFQt+uip8JxT8W4sdQLQQIpe2Od0IUSYfuQjAlDPqxuW2MZ+b9F7I8OCaGCL 82ZWvloz8QM3jtR5wNDEZCBt05LNt77h80v/C+TY0cDO9VPTyrZQuRla62Om+G8V XRaaH15e7V0Cn6GXEgjp47S90qEekkP8DcTVAAB9ua7Mxh+HcJ5yEOM1oQBm+nls dtGSnJIV1X2FKCCgaya3qtfpDmwYm4AEcviW+9JDxBkcrDbTz4arSWXHV3iS/mxy zWQIwv1Y7XtlBXxHN9BxKKd0Wu5033v4J4auyw8gPXT3ny9bu85I58d1/pqO+K4= =LmtF -----END PGP SIGNATURE----- --BCGnoucBdqqh6Wvp7PAFuJtx2fglo4g9o--