From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLJnu-0002xm-Es for qemu-devel@nongnu.org; Wed, 05 Mar 2014 16:56:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLJnp-0007Kf-HB for qemu-devel@nongnu.org; Wed, 05 Mar 2014 16:56:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27575) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLJnp-0007KS-8O for qemu-devel@nongnu.org; Wed, 05 Mar 2014 16:56:37 -0500 Message-ID: <531792E8.5080901@redhat.com> Date: Wed, 05 Mar 2014 14:11:04 -0700 From: Eric Blake MIME-Version: 1.0 References: <1394053327-27964-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1394053327-27964-1-git-send-email-sw@weilnetz.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CspmNEvUVBSPVvWrPPGLVxSSjCDnE74Bk" Subject: Re: [Qemu-devel] [PATCH] qjson.h: Remove GCC_FMT_ATTR markup from qobject_from_jsonv() declaration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , qemu-devel@nongnu.org, Peter Maydell Cc: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CspmNEvUVBSPVvWrPPGLVxSSjCDnE74Bk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/05/2014 02:02 PM, Stefan Weil wrote: > Commit aa830cdc28edb69c1fe81c8fd9471ab288ad0926 removed that attribute > from qobject_from_json. Now gcc suggests to add it again when compiler > flag -Wmissing-format-attribute is used: >=20 > qobject/qjson.c: In function =E2=80=98qobject_from_json=E2=80=99: > qobject/qjson.c:53:5: error: > function might be possible candidate for =E2=80=98gnu_printf=E2=80=99 = format attribute > [-Werror=3Dsuggest-attribute=3Dformat] >=20 > Fix this by removing the flag from qobject_from_jsonv, too. NAK. qobject_from_jsonv needs the attribute. Maybe this is a better approach (untested): diff --git i/qobject/qjson.c w/qobject/qjson.c index 6cf2511..f9616f8 100644 --- i/qobject/qjson.c +++ w/qobject/qjson.c @@ -50,7 +50,7 @@ QObject *qobject_from_jsonv(const char *string, va_list *ap) QObject *qobject_from_json(const char *string) { - return qobject_from_jsonv(string, NULL); + return qobject_from_jsonf("%s", string); } /* --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CspmNEvUVBSPVvWrPPGLVxSSjCDnE74Bk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTF5LoAAoJEKeha0olJ0Nq/h0H/1Fe9ZQ5Hp6qlEna89n+z2Sa msW6Xir9d2CoOKDTEsFhVME9w5RFCK5H7bQ1d9KhAvHY7B7gVenDyPKdQhvQ5vfT OXre+0BKlhrxFU8EwZr7pmpuU44ouzGMuDj5+ofKivXdBBPbfA6sy0ngGu5vsfC3 XKWPNjt8bTsreYNjkAw41SvzH9YQ4TJhNQdHL4mYRNvHCMuBaqqXeXzDrcCrH3lc IWKCzyQ91LwWN0c7aNapR/lHzH0VYU6iv+xiugECxjDW1neAo10JdXdTu7xLWMGv O/2Vpz+BchBOG6bfKpJ7bJxMmOSotksYy/Mbs3D4AHYeSoJmrVL7rc+dt/ls2q4= =5GP6 -----END PGP SIGNATURE----- --CspmNEvUVBSPVvWrPPGLVxSSjCDnE74Bk--