From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35814) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLJGr-0001Mr-5s for qemu-devel@nongnu.org; Wed, 05 Mar 2014 16:22:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLJGp-0004U7-TS for qemu-devel@nongnu.org; Wed, 05 Mar 2014 16:22:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1937) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLJGp-0004Tz-Jq for qemu-devel@nongnu.org; Wed, 05 Mar 2014 16:22:31 -0500 Message-ID: <5317958C.2060009@redhat.com> Date: Wed, 05 Mar 2014 14:22:20 -0700 From: Eric Blake MIME-Version: 1.0 References: <1394028740-710822-1-git-send-email-anton.ivanov@kot-begemot.co.uk> In-Reply-To: <1394028740-710822-1-git-send-email-anton.ivanov@kot-begemot.co.uk> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cRdXlptM4eTW9qSj0aoRIgTSq9Bkc8cgE" Subject: Re: [Qemu-devel] [PATCH] New feature - RFC3931 L2TPv3 network transport using static Ethernet over L2TPv3 tunnels List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anton.ivanov@kot-begemot.co.uk, qemu-devel@nongnu.org Cc: Anton Ivanov , pbonzini@redhat.com, afaerber@suse.de, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cRdXlptM4eTW9qSj0aoRIgTSq9Bkc8cgE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/05/2014 07:12 AM, anton.ivanov@kot-begemot.co.uk wrote: > From: Anton Ivanov >=20 > This transport allows qemu to communicate with host if host > supports L2TPv3, communicate directly VM to VM (similar to > current socket transport) and VM to other device - f.e. VM to > a router. >=20 > Supported > * Raw IPv4, Raw IPv6, UDPv4 and UDPv6 as per RFC > * No cookie, 32 bit cookie or 64 bit cookie > * Counter (as per RFC) > * No counter (draft-mkonstan-keyed-ipv6-tunnel-00) > Unsupported > * Workarounds for implementation with broken counter handling Just an interface review (leaving the technical review to others more knowledgeable on networking): > +++ b/qapi-schema.json > @@ -2940,6 +2940,57 @@ > '*localaddr': 'str', > '*udp': 'str' } } > =20 > +# @NetdevL2TPv3Options > +# > +# Connect the VLAN to Ethernet over L2TPv3 Static tunnel > +# > +# @src :source address s/ :/: / > +# > +# @dst :destination address and again > +# > +# @srcport :#optional source port - mandatory for udp, optional for ip= and again (several times more) udp is layer 3, ip is layer 2 - don't you mean "optional for tcp" as the layer 3 counterpart of udp? > +# > +# @dstport :#optional destination port - mandatory for udp, optional f= or ip > +# > +# @ipv6 :#optional - force the use of ipv6=20 > +# > +# @udp :#optional - use the udp version of l2tpv3 encapsulation > +# > +# @cookie64:#optional - use 64 bit coookies s/:/: / > +# > +# @counter :#optional have sequence counter > +#=20 > +# @txcookie :#optional 32 or 64 bit transmit cookie=20 > +#=20 > +# @rxcookie :#optional 32 or 64 bit receive cookie=20 > +#=20 > +# @txsession : 32 bit transmit session s/ :/:/ > +#=20 > +# @rxsession : 32 bit receive session - if not specified set to the sa= me value as transmit Long line, please wrap to keep within 80 columns > +#=20 > +# @optional : additional offset - allows the insertion of additional a= pplication-specific data before the packet payload another long line > +#=20 > +# > +# Since 1.2 At this point, you've pretty much missed the 2.0 feature freeze. So the earliest this can be is 2.1. Specifying 1.2 is wrong either way. > +## > +## > +{ 'type': 'NetdevL2TPv3Options', > + 'data': { > + 'src': 'str',=20 TAB damage and trailing whitespace. Please run your patch through scripts/checkpatch.pl, and only use spaces in the .json file. > + 'dst': 'str',=20 > + '*srcport': 'str',=20 > + '*dstport': 'str',=20 > + '*ipv6': 'bool',=20 > + '*udp': 'bool',=20 > + '*cookie64': 'bool', Indentation looks funky - either use a single space after : in all cases, or align all types to the same column (I don't care which, as long as it isn't the mismatch of random alignments that you currently hav= e) But looking better than the earlier version. On your next submission, be sure to use 'git send-email --subject-prefix=3DPATCHv2' to make it obvious that you are sending a new version. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --cRdXlptM4eTW9qSj0aoRIgTSq9Bkc8cgE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTF5WMAAoJEKeha0olJ0Nqe2EH+wRsqipVDUhHPIpy1UV3mGKv GoEGiBU9Fnyw7E6AeIlGTb0t35TY72OmDi/dkxrpubcKozOAhy518Kv85TMemetN 8oSwGYB0Ete9cCBTvPeKWjI7sPNyh4q5qBVEJDHovxl3hQXwPMwQYJ/wrvAHYmUE VZMnKqQNhHuc9Z3Lmpgsp+2wiYaFbSTn2hKtCjF7Apq4gA70yJqjOMJ/jGl/QrSq 2B5z8GY4vSbzS8LtHUPSe7W9RjsD+AfA6afx+kWoSucTVcBD51GmoD3nQCLjYvmi C5G2UOXzDVyWJd5KQPk4XiXjNtAvVpKMN+s6a1/RVV0MOGlhFHh1ZWcbeXYdqD8= =NeQ8 -----END PGP SIGNATURE----- --cRdXlptM4eTW9qSj0aoRIgTSq9Bkc8cgE--