From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLZgr-0004QU-At for qemu-devel@nongnu.org; Thu, 06 Mar 2014 09:54:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLZgf-0001q9-Fk for qemu-devel@nongnu.org; Thu, 06 Mar 2014 09:54:29 -0500 Received: from e37.co.us.ibm.com ([32.97.110.158]:58706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLZgf-0001pr-9C for qemu-devel@nongnu.org; Thu, 06 Mar 2014 09:54:17 -0500 Received: from /spool/local by e37.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 6 Mar 2014 07:54:14 -0700 Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id 900E819D8045 for ; Thu, 6 Mar 2014 07:54:09 -0700 (MST) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by b03cxnp08027.gho.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s26Erh9F9634060 for ; Thu, 6 Mar 2014 15:53:43 +0100 Received: from d03av02.boulder.ibm.com (localhost [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s26EsB86023503 for ; Thu, 6 Mar 2014 07:54:11 -0700 Message-ID: <53188C12.5010605@linux.vnet.ibm.com> Date: Thu, 06 Mar 2014 09:54:10 -0500 From: "Jason J. Herne" MIME-Version: 1.0 References: <1393435114-26374-1-git-send-email-jjherne@us.ibm.com> <1393435114-26374-3-git-send-email-jjherne@us.ibm.com> <5310B993.6080809@suse.de> In-Reply-To: <5310B993.6080809@suse.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 2/4] s390-cpu: ipi_states enhancements Reply-To: jjherne@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= , "Jason J. Herne" , borntraeger@de.ibm.com Cc: agraf@suse.de, qemu-devel@nongnu.org On 02/28/2014 11:30 AM, Andreas Färber wrote: > Am 26.02.2014 18:18, schrieb Jason J. Herne: >> From: "Jason J. Herne" >> >> Modify s390_cpu_addr2state to allow fetching state information for cpu addresses >> above smp_cpus. Hotplug requires this capability. >> >> Also add s390_cpu_set_state function to allow modification of ipi_state entries >> during hotplug. >> >> Signed-off-by: Jason J. Herne > > This patch is *still* present despite your previous response that you > incorporated my review comments. You are adding a custom s390x API here > rather than reusing the generic QOM API as requested. I don't even read > further in such cases - like I pointed out, a pure resend is not helping > address review feedback! > > Andreas > Andreas, My apologies, I am not trying to ruffle any feathers and I certainly have not intended to make you feel like I've ignored your review comments. I believe, if you look at patches 3 and 4 you will find that I've address the majority of your comments. I've even completed the work that adds the link property as you have suggested. The reason the ipi_array still exists in my patch set is because I was under the impression that we needed it to still exist. This belief stemmed from a misunderstanding I had related to an earlier e-mail discussion. I apologize for getting that detail wrong. I had assumed we would make use of the link property when possible but still keep the array around too. At this point, I only have one concern about removing the array. ipi_states is accessed from some high frequency code paths dealing with interrupt handling. I have not yet looked into it myself, but I trust I would find that retrieving the link property value would not significantly affect performance? Thank you for taking the time to read this patch set. Please let me know if you have any more concerns. I'm happy to work with you to address them. P.S. Sorry for taking so long to respond, I was away on vacation for a few days and I was not checking mail. -- -- Jason J. Herne (jjherne@linux.vnet.ibm.com)