From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60473) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLb0A-00017c-7U for qemu-devel@nongnu.org; Thu, 06 Mar 2014 11:18:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLb05-00078f-5E for qemu-devel@nongnu.org; Thu, 06 Mar 2014 11:18:30 -0500 Message-ID: <53189FCE.2010601@suse.de> Date: Thu, 06 Mar 2014 17:18:22 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1394075460-17400-1-git-send-email-aik@ozlabs.ru> In-Reply-To: <1394075460-17400-1-git-send-email-aik@ozlabs.ru> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] spapr-pci: change the default PCI bus naming List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org Cc: Paolo Bonzini , qemu-ppc@nongnu.org, Alexander Graf , Hong-Hua Yin Am 06.03.2014 04:11, schrieb Alexey Kardashevskiy: > Previously libvirt required the first/default PCI bus to have name "pci= ". > Since QEMU can support multiple buses now, libvirt wants "pci.0" now. >=20 > This removes custom busname and lets QEMU make up default names. >=20 > Signed-off-by: Alexey Kardashevskiy > --- >=20 > I tested this with: > -netdev tap,id=3Did0,ifname=3Dtapqemu-tap-00,script=3Difup.sh,downscr= ipt=3Difdown.sh \ > -device e1000,id=3Did1,netdev=3Did0,mac=3DC0:41:49:4b:00:00 \ > -device \ > spapr-pci-host-bridge,index=3D5,id=3Daikbus \ > -netdev tap,id=3Did2,ifname=3Dtap-1,script=3Difup.sh,downscript=3Difd= own.sh \ > -device rtl8139,id=3Did3,netdev=3Did2,bus=3Daikbus.0,mac=3DC0:41:49:4= b:00:01 \ > -device spapr-pci-vfio-host-bridge,id=3Did4,index=3D10,iommu=3D4 \ >=20 > This creates a default PCI, an additional emulated PCI bus (named aikbu= s, aikbus.0 for the bus according to example and info qtree, but yeah ;) > if I omit the name, it is pci.1 which is also fine) and VFIO bus (which= is > not in upstream yet but still), this all works fine and I cannot see an= y flaw. >=20 >=20 > --- > hw/ppc/spapr_pci.c | 23 ++--------------------- > 1 file changed, 2 insertions(+), 21 deletions(-) Thanks, in absence of Alex applying to qom-next: https://github.com/afaerber/qemu-cpu/commits/qom-next Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg