From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLb4F-0005Jl-Fy for qemu-devel@nongnu.org; Thu, 06 Mar 2014 11:22:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLb4A-0000FW-KG for qemu-devel@nongnu.org; Thu, 06 Mar 2014 11:22:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47911) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLb4A-0000FL-5q for qemu-devel@nongnu.org; Thu, 06 Mar 2014 11:22:38 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s26GMbko026147 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 6 Mar 2014 11:22:37 -0500 Message-ID: <5318A0CC.6050108@redhat.com> Date: Thu, 06 Mar 2014 09:22:36 -0700 From: Eric Blake MIME-Version: 1.0 References: <1394120669-4675-1-git-send-email-kwolf@redhat.com> <1394120669-4675-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1394120669-4675-3-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WHlruuAdeTXjuktoUJvr9KcRk664j6NqM" Subject: Re: [Qemu-devel] [PATCH 2/3] blockdev: Fix NULL pointer dereference in blockdev-add List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: armbru@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WHlruuAdeTXjuktoUJvr9KcRk664j6NqM Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/06/2014 08:44 AM, Kevin Wolf wrote: > If aio=3Dnative, we check that cache.direct is set as well. If however > cache wasn't specified at all, qemu just segfaulted. >=20 > The old condition didn't make any sense anyway because it effectively > only checked for the default cache mode case, but not for an explicitly= > set cache.direct=3Doff mode. >=20 > Signed-off-by: Kevin Wolf > --- > blockdev.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --WHlruuAdeTXjuktoUJvr9KcRk664j6NqM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTGKDMAAoJEKeha0olJ0Nq+vkH/1d1d26SV0vqeTA70R4lkr+O /5LZHABwXSG9RXz1QjO4NM7fGHJuJovORaY9ajxWQssADKHXK8hlF1r2CMY7w31V owXFYAwUBlcMltZ30k4sV47TT7pPT4eBNW8XJCJooYTJ94lTGRGcWNxXzbSvWXt+ qQj5lxPWlJzDo8XgiI+akmm8NLj3CrbAWJsDG+4NVyxLRY581cue11Aq0XLN1GMo VTgrEVULoUl5Tcs9UoB753zH3R+B8nPJcdFTfeKxRTTcY4uyz9+mly9cAVCPR6VI /te2DcsXp/QJPYphoYRqq+JGPDbbpLGJc1bAfg3A05o50J+tcR6esBkwa9vWgZU= =czPb -----END PGP SIGNATURE----- --WHlruuAdeTXjuktoUJvr9KcRk664j6NqM--