From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33614) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLb55-0006R7-GZ for qemu-devel@nongnu.org; Thu, 06 Mar 2014 11:23:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLb4w-0000Q3-In for qemu-devel@nongnu.org; Thu, 06 Mar 2014 11:23:35 -0500 Received: from e35.co.us.ibm.com ([32.97.110.153]:43683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLb4w-0000Px-AH for qemu-devel@nongnu.org; Thu, 06 Mar 2014 11:23:26 -0500 Received: from /spool/local by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 6 Mar 2014 09:23:25 -0700 Received: from b03cxnp08027.gho.boulder.ibm.com (b03cxnp08027.gho.boulder.ibm.com [9.17.130.19]) by d03dlp01.boulder.ibm.com (Postfix) with ESMTP id 1A57C1FF001A for ; Thu, 6 Mar 2014 09:23:23 -0700 (MST) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by b03cxnp08027.gho.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s26GMsIu2687252 for ; Thu, 6 Mar 2014 17:22:54 +0100 Received: from d03av02.boulder.ibm.com (localhost [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s26GNMXL026985 for ; Thu, 6 Mar 2014 09:23:22 -0700 Message-ID: <5318A0F8.8020508@linux.vnet.ibm.com> Date: Thu, 06 Mar 2014 11:23:20 -0500 From: "Jason J. Herne" MIME-Version: 1.0 References: <1393435114-26374-1-git-send-email-jjherne@us.ibm.com> <1393435114-26374-3-git-send-email-jjherne@us.ibm.com> <5310B993.6080809@suse.de> In-Reply-To: <5310B993.6080809@suse.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 2/4] s390-cpu: ipi_states enhancements Reply-To: jjherne@linux.vnet.ibm.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= , "Jason J. Herne" , borntraeger@de.ibm.com Cc: agraf@suse.de, qemu-devel@nongnu.org On 02/28/2014 11:30 AM, Andreas Färber wrote: > Am 26.02.2014 18:18, schrieb Jason J. Herne: >> From: "Jason J. Herne" >> >> Modify s390_cpu_addr2state to allow fetching state information for cpu addresses >> above smp_cpus. Hotplug requires this capability. >> >> Also add s390_cpu_set_state function to allow modification of ipi_state entries >> during hotplug. >> >> Signed-off-by: Jason J. Herne > > This patch is *still* present despite your previous response that you > incorporated my review comments. You are adding a custom s390x API here > rather than reusing the generic QOM API as requested. I don't even read > further in such cases - like I pointed out, a pure resend is not helping > address review feedback! > > Andreas > Just a quick follow on note. Even though the link property has been added by this patch set, I just realized this part of the code is not yet complete. I'll work up a complete patch just to address this issue and post it separate from Hotplug. I think that makes the most sense because this is really a qom patch. -- -- Jason J. Herne (jjherne@linux.vnet.ibm.com)