From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLco9-0006l2-1q for qemu-devel@nongnu.org; Thu, 06 Mar 2014 13:14:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLco4-0000eR-6F for qemu-devel@nongnu.org; Thu, 06 Mar 2014 13:14:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57028) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLco3-0000dJ-UV for qemu-devel@nongnu.org; Thu, 06 Mar 2014 13:14:08 -0500 Message-ID: <5318BAE9.2080706@redhat.com> Date: Thu, 06 Mar 2014 11:14:01 -0700 From: Eric Blake MIME-Version: 1.0 References: <1388704234-22498-1-git-send-email-xiawenc@linux.vnet.ibm.com> <20140106181809.64b77df3@redhat.com> In-Reply-To: <20140106181809.64b77df3@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EJnKrkpa4RmCC9gvbOMNA3OL3bj3s2MWW" Subject: Re: [Qemu-devel] [RFC PATCH V2 0/5] add direct support of event in qapi schema List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino , Wenchao Xia Cc: mdroth@linux.vnet.ibm.com, mreitz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --EJnKrkpa4RmCC9gvbOMNA3OL3bj3s2MWW Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/06/2014 04:18 PM, Luiz Capitulino wrote: > On Fri, 3 Jan 2014 07:10:29 +0800 > Wenchao Xia wrote: >=20 >> This series add support for tag/keyword 'event' in qapi-schema. >> A new file was created to store some helper functions in patch 2, patc= h 4 is >> the test case, patch 5 is a convert example. >> >> The implemention is done by generate API and a batch of parameters for= each >> event define, it doesn't generate a struture and visit function in the= >> background for every event, so it doesn't support nested structure in = the >> define to avoid trouble. A callback layer is added to control the beha= vior. >> More detail can be found in patch 3's message and incode comments. >=20 > The general approach seems good to me. Would be nice to get another > reviewer though, maybe Eric and/or Michael. Just now looking at this thread. Is this still something that we want in 2.0, or at this point are we late enough to delay to 2.1? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --EJnKrkpa4RmCC9gvbOMNA3OL3bj3s2MWW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTGLrpAAoJEKeha0olJ0NqdCAH/jJ4zFm4CJB6otqK4dF7T/2S IuEJlSqMsn5Wtoxwx8qpsptWxmbeYlINESsweSGQW+KKaYESYwCwoVm3+n9w+ifh /b31U6VxkBLvUOdAeV54/gynxc5PG0n5garxx8VcNdxTKQySM5F69fHgO3TeB+WU A11p64L4CIWPIQfj3X+WP8r6eSLnQJciJ2WZOEBtfTO4tEd/o27MvjPLabhZkEIM phZkaVTHc2RzJlrpjhrO9jKS/MLYcMQiVwdBYI9jbInPTs1yl2iXOHT3Uu6isa3R ACAIsFxNZyiRBTSK7KOFTcnu7NpQgbMTbU0i+JGuaoYx8a71Zo95Fx885QX1q2U= =REEB -----END PGP SIGNATURE----- --EJnKrkpa4RmCC9gvbOMNA3OL3bj3s2MWW--