From: "Andreas Färber" <afaerber@suse.de>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] qdev-monitor-test: Simplify & make more robust
Date: Thu, 06 Mar 2014 20:16:47 +0100 [thread overview]
Message-ID: <5318C99F.2050005@suse.de> (raw)
In-Reply-To: <1394097173-14432-1-git-send-email-armbru@redhat.com>
Am 06.03.2014 10:12, schrieb Markus Armbruster:
> Stefan's patch has been rotting on the list since December. Reposting
> it together with a patch for a robustness issue I spotted when
> reviewing it.
Stefan had applied qdev-monitor-test through his block tree, and I was
on vacation for most of December and would've needed a ping or two in
the new year. qdev-monitor itself seems to be gray territory - I've been
taking care of QOM conversion issues but otherwise don't feel
responsible for the HMP/QMP interface and would expect the maintainer
that does feel responsible to handle the matching test cases.
> Markus Armbruster (1):
> qdev-monitor-test: Don't test human-readable error message
>
> Stefan Hajnoczi (1):
> qdev-monitor-test: simplify using g_assert_cmpstr()
>
> tests/qdev-monitor-test.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
Thanks, applied to qom-next:
https://github.com/afaerber/qemu-cpu/commits/qom-next
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-03-06 19:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 9:12 [Qemu-devel] [PATCH v2 0/2] qdev-monitor-test: Simplify & make more robust Markus Armbruster
2014-03-06 9:12 ` [Qemu-devel] [PATCH v2 1/2] qdev-monitor-test: simplify using g_assert_cmpstr() Markus Armbruster
2014-03-06 9:12 ` [Qemu-devel] [PATCH v2 2/2] qdev-monitor-test: Don't test human-readable error message Markus Armbruster
2014-03-06 16:26 ` [Qemu-devel] [PATCH v2 0/2] qdev-monitor-test: Simplify & make more robust Eric Blake
2014-03-06 16:55 ` Stefan Hajnoczi
2014-03-06 19:16 ` Andreas Färber [this message]
2014-03-07 9:59 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5318C99F.2050005@suse.de \
--to=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).