From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41856) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLedO-0003ug-Cc for qemu-devel@nongnu.org; Thu, 06 Mar 2014 15:11:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLedE-0007jI-84 for qemu-devel@nongnu.org; Thu, 06 Mar 2014 15:11:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47210) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLedD-0007jD-Vb for qemu-devel@nongnu.org; Thu, 06 Mar 2014 15:11:04 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s26KB2Io028890 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 6 Mar 2014 15:11:03 -0500 Message-ID: <5318D652.9080206@redhat.com> Date: Thu, 06 Mar 2014 21:10:58 +0100 From: Max Reitz MIME-Version: 1.0 References: <1394055700-5988-1-git-send-email-mreitz@redhat.com> <20140306125755.GE2663@dhcp-200-207.str.redhat.com> In-Reply-To: <20140306125755.GE2663@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/5] block/raw: Strip "file:" prefix from filenames List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, Stefan Hajnoczi On 06.03.2014 13:57, Kevin Wolf wrote: > Am 05.03.2014 um 22:41 hat Max Reitz geschrieben: >> The "file" protocol drivers (block/raw-posix and block/raw-win32) may be >> explicitly selected by prepending a "file:" prefix to a filename (as >> with all other block protocols). However, currently, they do not strip >> this prefix as they should. >> >> This series fixes this issue. > Thanks, applied to the block branch. > > This is just for consistency and there is no real use case for this, > right? If so, it would be even more consistent to do the same for the > host_* drivers provided by block/raw-{posix,win32}.c The use case would be that this allows explicitly specifying the prefix in order to create image files with a colon ("file:foo:bar.qcow2" for an image named "foo:bar.qcow2", although "./foo:bar.qcow2" works just as well). I only looked for the "file" protocol drivers, but I'll have a look for other protocol drivers which currently do not strip their prefix as well (such as host_*, yes). > I talked about this multiple times in discussions about handling colons > in filenames, so that prefixing file: would make it unambigious that the > colon is part of the file name and not a protocol name, but these days I > think we already have enough other ways to express this (the easiest > being ./test:foo, because protocols can't contain slashes) Yes, but considering my first idea was to explicitly state the "file" prefix instead of the simpler ./, maybe others think the same way. ;-) Max