From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44613) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLeqA-00085X-HO for qemu-devel@nongnu.org; Thu, 06 Mar 2014 15:24:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLeq3-0003BQ-Gu for qemu-devel@nongnu.org; Thu, 06 Mar 2014 15:24:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:20274) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLeq3-0003BF-7I for qemu-devel@nongnu.org; Thu, 06 Mar 2014 15:24:19 -0500 Message-ID: <5318D970.6070500@redhat.com> Date: Thu, 06 Mar 2014 13:24:16 -0700 From: Eric Blake MIME-Version: 1.0 References: <1388704234-22498-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1388704234-22498-6-git-send-email-xiawenc@linux.vnet.ibm.com> In-Reply-To: <1388704234-22498-6-git-send-email-xiawenc@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bwWRw7R2lECMq55jcF3ALWmPnrEBi5Rwg" Subject: Re: [Qemu-devel] [RFC PATCH V2 5/5] qapi event: convert RTC_CHANGE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia , qemu-devel@nongnu.org Cc: mreitz@redhat.com, armbru@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bwWRw7R2lECMq55jcF3ALWmPnrEBi5Rwg Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 01/02/2014 04:10 PM, Wenchao Xia wrote: > This is just an example of how to use qapi event API, and it > bypassed the event throttle queue. A complete convert should > be first define all events in qapi-schema.json, use qapi > event types in monitor functions, then change calller one s/calller/caller/ > by one. >=20 > Signed-off-by: Wenchao Xia > --- > monitor.c | 14 ++++++++++++++ > qapi-schema.json | 3 +++ > vl.c | 7 ++----- > 3 files changed, 19 insertions(+), 5 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -4247,3 +4247,6 @@ > # Since: 1.7 > ## > { 'command': 'blockdev-add', 'data': { 'options': 'BlockdevOptions' } = } > + > +{ 'event': 'RTC_CHANGE', You'll need to add documentation before each 'event' (hint - crib the existing documentation we already have in qmp-events.txt) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --bwWRw7R2lECMq55jcF3ALWmPnrEBi5Rwg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTGNlwAAoJEKeha0olJ0NqGocH/2P4DB6u4Vu1U1l7kp9Ya1uJ a4ajrVZXZW2wyf5ufO4jwYPlh3TppqYszkQ8NJOJgTizC2+cfGiVe+cLD8zcn+Lg jZVbtpsRaDxD46O3SxoiGyhZuRKLEutHJpqOhweXD+93zkNCfedj0nKRRfP0cGU4 esULpIjhphgsA0jQxu6WPk7KM45Y6HG4/2KlXNzBteVwmPWblCnaSamn8iPvihnX a9S+wh1G6sKiyZF0nRmtQToX58Ul2Cr3aSIZzWpB3f2mhmDQGPuvUyLCf3sB6CDX EiHqMBRB+slh2ajcLyPcSHjtYHbm0i9ULIC3KJNTiTNAut3IqAL/yrFM3IyT3mw= =PZN8 -----END PGP SIGNATURE----- --bwWRw7R2lECMq55jcF3ALWmPnrEBi5Rwg--