From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLjM4-0004Ll-JK for qemu-devel@nongnu.org; Thu, 06 Mar 2014 20:13:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLjLw-0000jX-6F for qemu-devel@nongnu.org; Thu, 06 Mar 2014 20:13:40 -0500 Received: from mail-pd0-x233.google.com ([2607:f8b0:400e:c02::233]:60742) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLjLw-0000jL-07 for qemu-devel@nongnu.org; Thu, 06 Mar 2014 20:13:32 -0500 Received: by mail-pd0-f179.google.com with SMTP id w10so3302749pde.24 for ; Thu, 06 Mar 2014 17:13:31 -0800 (PST) Message-ID: <53191D2D.2060001@gmail.com> Date: Fri, 07 Mar 2014 09:13:17 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1388704234-22498-1-git-send-email-xiawenc@linux.vnet.ibm.com> <20140106181809.64b77df3@redhat.com> <5318BAE9.2080706@redhat.com> <20140306145826.2d4410a5@redhat.com> In-Reply-To: <20140306145826.2d4410a5@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC PATCH V2 0/5] add direct support of event in qapi schema List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: mdroth@linux.vnet.ibm.com, armbru@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com, Wenchao Xia 于 2014/3/7 3:58, Luiz Capitulino 写道: > On Thu, 06 Mar 2014 11:14:01 -0700 > Eric Blake wrote: > >> On 01/06/2014 04:18 PM, Luiz Capitulino wrote: >>> On Fri, 3 Jan 2014 07:10:29 +0800 >>> Wenchao Xia wrote: >>> >>>> This series add support for tag/keyword 'event' in qapi-schema. >>>> A new file was created to store some helper functions in patch 2, patch 4 is >>>> the test case, patch 5 is a convert example. >>>> >>>> The implemention is done by generate API and a batch of parameters for each >>>> event define, it doesn't generate a struture and visit function in the >>>> background for every event, so it doesn't support nested structure in the >>>> define to avoid trouble. A callback layer is added to control the behavior. >>>> More detail can be found in patch 3's message and incode comments. >>> The general approach seems good to me. Would be nice to get another >>> reviewer though, maybe Eric and/or Michael. >> Just now looking at this thread. Is this still something that we want >> in 2.0, or at this point are we late enough to delay to 2.1? > We could get this in if we get it posted and fully reviewed before hard freeze > (which is on March 12). But I'd suggest postponing to 2.1. > There is still something not solved perfectly, I'll update later,guess it can't catch up with 2.0.