From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLmHd-00089X-R4 for qemu-devel@nongnu.org; Thu, 06 Mar 2014 23:21:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLmHZ-0006V8-GC for qemu-devel@nongnu.org; Thu, 06 Mar 2014 23:21:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61458) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLmHZ-0006Ur-7k for qemu-devel@nongnu.org; Thu, 06 Mar 2014 23:21:13 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s274LBoG030283 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 6 Mar 2014 23:21:12 -0500 Message-ID: <53194936.9000606@redhat.com> Date: Thu, 06 Mar 2014 21:21:10 -0700 From: Eric Blake MIME-Version: 1.0 References: <20140307004004.GA6114@amt.cnet> In-Reply-To: <20140307004004.GA6114@amt.cnet> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="f4ae8lAgp7QwEcs6QdHSnJOtx4fDUeeuc" Subject: Re: [Qemu-devel] [PATCH] mempath: add option to specify minimum huge page size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcelo Tosatti , qemu-devel Cc: Paolo Bonzini , Igor Mammedov This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --f4ae8lAgp7QwEcs6QdHSnJOtx4fDUeeuc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/06/2014 05:40 PM, Marcelo Tosatti wrote: >=20 > Failing initialization in case hugepage path has=20 > hugepage smaller than specified. >=20 > Signed-off-by: Marcelo Tosatti >=20 > diff --git a/exec.c b/exec.c > index b69fd29..c95a0f3 100644 > --- a/exec.c > +++ b/exec.c > }; > =20 > +static QemuOptsList qemu_mempath_opts =3D { > + .name =3D "mem-path", > - case QEMU_OPTION_mempath: > - mem_path =3D optarg; > + case QEMU_OPTION_mempath: { > + opts =3D qemu_opts_parse(qemu_find_opts("mem-path"), o= ptarg, 1); Pre-existing, but this is yet another inconsistent naming between C objects and the command line. If we were consistent, it should be named QEMU_OPTION_mem_path, and qemu_mem_path_options. (See my recent complaint about other misnamed options: https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg01131.html) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --f4ae8lAgp7QwEcs6QdHSnJOtx4fDUeeuc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTGUk2AAoJEKeha0olJ0NqL2IH/j2atgf4WOAM3LVaSG6Obvqh EBhSoIBN5brX/N+YO4j6a0bfHCGu6XghsDV6X2gZHlRQHeFHGfteEMd/gTpSbEki CYjPxlNCFMNqtIJMJBQg28PS8EN7PZvmW6d1sAzZ4KQHcaKmNlYV1hieDh8Inie+ U/80BFTAkTAuKgZB1AB5/cXd+KEnP4t0ywFWQb5KWaQ+I+rrtkZEZfxHssJCyl8h tqvJ3thI66SV4p9nWaahcm/40mi/wdBvdaiLpc/bFsv57oaEKwFm02UNWOssoU2b DLD8rQA41N94DqQg8A/iD9szv///s8U+IyLeUq7tRphOE68kmQoE8OEEp+JMK/E= =nG17 -----END PGP SIGNATURE----- --f4ae8lAgp7QwEcs6QdHSnJOtx4fDUeeuc--